-
Notifications
You must be signed in to change notification settings - Fork 5k
Refactor Problems API #27184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Problems API #27184
Conversation
39aa506
to
e82df22
Compare
e82df22
to
354221f
Compare
354221f
to
37826c3
Compare
aff719f
to
23d7979
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx
LGTM
} | ||
@Nullable | ||
|
||
@Override |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❔ is this implicitely nullable because the constructor parameter is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably. It doesn't matter really as I'm working hard to refactor that part of the API separately.
23d7979
to
71384d2
Compare
- Remove stepwise builder - Remove ProblemBuilder.undocumented() and ProblemBuilder.noLocation() - Allow Problems API to define namespace - Separate private and public Problems API interface - Make transformers internal - Add ProblemBuilder.documentedAt(String) - Make problem instances not reference the Problems service - Make public API expose minimal set of features - Replace ProblemBuilder with Action<ProblemSpec> - ProblemBuilder extends ProblemSpec - Require exception in ProbemReporter.throwing(Action) - Move and cleanup ProblemLocation and its subclasses - Clean up task path location and rename identityPath to buildTreePath - Represent buildTreePath with String
71384d2
to
9e83bc6
Compare
WARN: This is a feature pull request but no changes to release note found. |
This PR contains the following changes: - Remove stepwise builder - Remove ProblemBuilder.undocumented() and ProblemBuilder.noLocation() - Allow Problems API to define namespace - Separate private and public Problems API interface - Make transformers internal - Add ProblemBuilder.documentedAt(String) - Make problem instances not reference the Problems service - Make public API expose minimal set of features - Replace ProblemBuilder with Action<ProblemSpec> - ProblemBuilder extends ProblemSpec - Require exception in ProbemReporter.throwing(Action) - Move and cleanup ProblemLocation and its subclasses - Clean up task path location and rename identityPath to buildTreePath - Represent buildTreePath with String ## Reviewing cheatsheet ### Before merging the PR, comments starting with ❌ ❓must be fixed 🤔 💅 should be fixed 💭 may be fixed 🎉 celebrate happy things Co-authored-by: Donát Csikós <[email protected]>
The SSL certificate for the groovy-lang.org domain has just expired
@bot-gradle merge |
WARN: This is a feature pull request but no changes to release note found. |
Your PR is queued. See the queue page for details. |
Pre-tested commit build failed. Click here to see all build failures. |
This PR contains the following changes: - Remove stepwise builder - Remove ProblemBuilder.undocumented() and ProblemBuilder.noLocation() - Allow Problems API to define namespace - Separate private and public Problems API interface - Make transformers internal - Add ProblemBuilder.documentedAt(String) - Make problem instances not reference the Problems service - Make public API expose minimal set of features - Replace ProblemBuilder with Action<ProblemSpec> - ProblemBuilder extends ProblemSpec - Require exception in ProbemReporter.throwing(Action) - Move and cleanup ProblemLocation and its subclasses - Clean up task path location and rename identityPath to buildTreePath - Represent buildTreePath with String ## Reviewing cheatsheet ### Before merging the PR, comments starting with ❌ ❓must be fixed 🤔 💅 should be fixed 💭 may be fixed 🎉 celebrate happy things Co-authored-by: Donát Csikós <[email protected]>
Your PR is queued. See the queue page for details. |
Error while scheduling pre-tested commit, please contact the administrator. |
This PR contains the following changes:
Reviewing cheatsheet
Before merging the PR, comments starting with