Skip to content

Use the vanilla kotlin-compiler-embeddable #21298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2022
Merged

Use the vanilla kotlin-compiler-embeddable #21298

merged 1 commit into from
Jul 20, 2022

Conversation

eskatos
Copy link
Member

@eskatos eskatos commented Jul 20, 2022

Before this PR the Gradle distribution contains a custom patched version of the org.jetbrains.kotlin:kotlin-compiler-embeddable. After this PR the vanilla artifact is used.

This removes complexity from the gradle/gradle build and reason of confusion from the Gradle distribution.

@eskatos eskatos added a:chore Minor issue without significant impact in:building-gradle gradle/gradle build in:kotlin-dsl labels Jul 20, 2022
@eskatos eskatos added this to the 7.6 RC1 milestone Jul 20, 2022
@eskatos eskatos self-assigned this Jul 20, 2022
@eskatos eskatos force-pushed the eskatos/kotlin-dsl/vanilla-kotlin-compiler-embeddable branch from 457ab2e to c3441f8 Compare July 20, 2022 09:08
@eskatos eskatos requested review from bamboo and lptr July 20, 2022 09:09
@eskatos eskatos marked this pull request as ready for review July 20, 2022 09:10
@eskatos eskatos force-pushed the eskatos/kotlin-dsl/vanilla-kotlin-compiler-embeddable branch from c3441f8 to faa6273 Compare July 20, 2022 10:20
@gradle gradle deleted a comment from eskatos Jul 20, 2022
bamboo
bamboo approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@bamboo bamboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@eskatos
Copy link
Member Author

eskatos commented Jul 20, 2022

@bot-gradle test RFR

@gradle gradle deleted a comment from eskatos Jul 20, 2022
@bot-gradle
Copy link
Collaborator

OK, I've already triggered the following builds for you:

@eskatos
Copy link
Member Author

eskatos commented Jul 20, 2022

Thanks for the review Rodrigo!

@bot-gradle test and merge

@gradle gradle deleted a comment from eskatos Jul 20, 2022
@bot-gradle
Copy link
Collaborator

OK, I've already triggered a build for you.

@eskatos eskatos removed the request for review from lptr July 20, 2022 13:35
@bot-gradle bot-gradle merged commit 9321325 into master Jul 20, 2022
@eskatos eskatos deleted the eskatos/kotlin-dsl/vanilla-kotlin-compiler-embeddable branch July 20, 2022 15:22
This was referenced Jul 20, 2022
Merged
Merged
@lptr
Copy link
Member

lptr commented Jul 22, 2022

Yay! <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bamboo bamboo bamboo approved these changes

Assignees

@eskatos eskatos

Labels

a:chore Minor issue without significant impact in:building-gradle gradle/gradle build in:kotlin-dsl

Projects

None yet

Milestone

7.6 RC1

Development

Successfully merging this pull request may close these issues.

4 participants

@eskatos @bot-gradle @lptr @bamboo