Skip to content

Conversation

eskatos
Copy link
Member

@eskatos eskatos commented Jun 16, 2022

While keeping target api/language to 1.4 for backwards compatibility.

Found issues:


New sample rendered for review:
https://builds.gradle.org/repository/download/Gradle_Master_Check_BuildDistributions/53841869:id/distributions/gradle-7.6-docs.zip!/gradle-7.6-20220713055324%2B0000/docs/userguide/toolchains.html#integration_with_tasks_relying_on_a_java_executable_or_java_home


Follow ups to be done in subsequent PR(s)

@eskatos eskatos added a:feature A new functionality in:kotlin-dsl labels Jun 16, 2022
@eskatos eskatos added this to the 7.6 RC1 milestone Jun 16, 2022
@eskatos eskatos self-assigned this Jun 16, 2022
@eskatos eskatos force-pushed the eskatos/kotlin/embedded-1.7.0 branch 2 times, most recently from 6bd5173 to 6616ad8 Compare June 17, 2022 09:32
bot-gradle added a commit that referenced this pull request Jun 22, 2022
As a preparation for #21032

Along the way:
* upgrade smoke tested `ktlint-gradle` version
* upgrade `ktlint` usage in `:quickCheck` and mark that task as not compatible with configuration caching

### Context
<!--- Why do you believe many users will benefit from this change? -->
<!--- Link to relevant issues or forum discussions here -->

### Contributor Checklist
- [ ] [Review Contribution Guidelines](https://github.com/gradle/gradle/blob/master/CONTRIBUTING.md)
- [ ] Make sure that all commits are [signed off](https://git-scm.com/docs/git-commit#Documentation/git-commit.txt---signoff) to indicate that you agree to the terms of [Developer Certificate of Origin](https://developercertificate.org/).
- [ ] Make sure all contributed code can be distributed under the terms of the [Apache License 2.0](https://github.com/gradle/gradle/blob/master/LICENSE), e.g. the code was written by yourself or the original code is licensed under [a license compatible to Apache License 2.0](https://apache.org/legal/resolved.html).
- [ ] Check ["Allow edit from maintainers" option](https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/) in pull request so that additional changes can be pushed by Gradle team
- [ ] Provide integration tests (under `<subproject>/src/integTest`) to verify changes from a user perspective
- [ ] Provide unit tests (under `<subproject>/src/test`) to verify logic
- [ ] Update User Guide, DSL Reference, and Javadoc for public-facing changes
- [ ] Ensure that tests pass sanity check: `./gradlew sanityCheck`
- [ ] Ensure that tests pass locally: `./gradlew <changed-subproject>:quickTest`

### Gradle Core Team Checklist
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation
- [ ] Recognize contributor in release notes

Co-authored-by: Paul Merlin <[email protected]>
@eskatos eskatos force-pushed the eskatos/kotlin/embedded-1.7.0 branch 4 times, most recently from 4df8af7 to c9b519e Compare June 28, 2022 13:20
@gradle gradle deleted a comment from eskatos Jun 28, 2022
@eskatos eskatos changed the title Upgrade embedded Kotlin to 1.7.0 Upgrade embedded Kotlin to 1.7.10 Jun 29, 2022
@eskatos eskatos force-pushed the eskatos/kotlin/embedded-1.7.0 branch 5 times, most recently from c2be7b2 to eb5443a Compare June 30, 2022 08:22
@gradle gradle deleted a comment from eskatos Jun 30, 2022
@eskatos eskatos force-pushed the eskatos/kotlin/embedded-1.7.0 branch from 7e27cff to b86c430 Compare July 12, 2022 09:15
@gradle gradle deleted a comment from eskatos Jul 12, 2022
@gradle gradle deleted a comment from eskatos Jul 12, 2022
@eskatos eskatos force-pushed the eskatos/kotlin/embedded-1.7.0 branch from f1923de to 358d157 Compare July 12, 2022 14:59
@gradle gradle deleted a comment from eskatos Jul 12, 2022
eskatos added 16 commits July 13, 2022 07:44
For the upgrade to Kotlin 1.7

Signed-off-by: Paul Merlin <[email protected]>
for next development iteration

Signed-off-by: Paul Merlin <[email protected]>
The `toolchain-kotlin` sample was broken because `kotlinOptions.jdkHome` has
been deprecated for a while and removed in Kotlin 1.7.0.

Introduce a new sample that doesn't rely on third party plugins and adjust
the documentation chapter.

Signed-off-by: Paul Merlin <[email protected]>
Signed-off-by: Paul Merlin <[email protected]>
Signed-off-by: Paul Merlin <[email protected]>
Signed-off-by: Paul Merlin <[email protected]>
The underlying issue is fixed since Kotlin 1.5.31
and now causes problems with Kotlin 1.7.x

Signed-off-by: Paul Merlin <[email protected]>