Upgrade ktlint-convention plugin to 0.8.0 #21066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Merlin <[email protected]>
Signed-off-by: Paul Merlin <[email protected]>
Signed-off-by: Paul Merlin <[email protected]>
Signed-off-by: Paul Merlin <[email protected]>
Signed-off-by: Paul Merlin <[email protected]>
Signed-off-by: Paul Merlin <[email protected]>
5 tasks
Signed-off-by: Paul Merlin <[email protected]>
|
@bot-gradle test this |
|
OK, I've already triggered the following builds for you: |
eskatos
commented
Jun 22, 2022
|
|
||
| ktlint { | ||
| version.set("0.41.0") | ||
| } |
There was a problem hiding this comment.
This is not needed anymore as we can now use the default version
|
@bot-gradle test and merge |
|
OK, I've already triggered a build for you. |
bot-gradle
added a commit
that referenced
this pull request
Jul 19, 2022
While keeping target api/language to 1.4 for backwards compatibility. Found issues: * [x] ~Internal Kotlin compiler API now requires JDK_HOME to be set~ * [x] ~Internal Kotlin compiler API now requires JDK roots to be explicitely set to work on Java >= 18~ * [x] ~`ktlint-convention` plugin needs an upgrade~ ~#21066 * [x] ~JVM toolchain documentation snippet to set tool on community plugin task needs to be changed as `KotlinCompile.kotlinOptions.jdkHome` has been deprecated and removed~ * [x] ~Errors resolving KGP variants~ * ~`samples/build-organization/structuring-software-projects` is broken by KGP variant resolution errors~ * ~Upgrading in build init plugin causes KGP variant resolution errors in `buildSrc`~ * ~Blocked on https://youtrack.jetbrains.com/issue/KT-52987/Allow-to-disable-adding-orgjetbrainskotlinplatformtype-attribute-to-outgoing-variants which means **we need to wait for Kotlin 1.7.10**~ ---- New sample rendered for review: https://builds.gradle.org/repository/download/Gradle_Master_Check_BuildDistributions/53841869:id/distributions/gradle-7.6-docs.zip!/gradle-7.6-20220713055324%2B0000/docs/userguide/toolchains.html#integration_with_tasks_relying_on_a_java_executable_or_java_home ---- Follow ups to be done in subsequent PR(s) * Update the wrapper and remove branching in `build-logic-commons/gradle-plugin/build.gradle.kts` * Review `kotlin-compiler-embeddable` patching Co-authored-by: Paul Merlin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a preparation for #21032
Along the way:
ktlint-gradleversionktlintusage in:quickCheckand mark that task as not compatible with configuration cachingContext
Contributor Checklist
<subproject>/src/integTest) to verify changes from a user perspective<subproject>/src/test) to verify logic./gradlew sanityCheck./gradlew <changed-subproject>:quickTestGradle Core Team Checklist