-
Notifications
You must be signed in to change notification settings - Fork 5k
Update Groovy to 3.0.8 for JDK17 support #17712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
For some reason with Groovy 3.0.8, derivatives of this Java class, which are Groovy classes fail to compile in a weird way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment about the dependency verification changes, otherwise I am OK with the workarounds for Groovy bugs since they affect only test code.
gradle/verification-metadata.xml
Outdated
<pgp value="34441e504a937f43eb0daef96a65176a0fb1cd0b"/> | ||
</artifact> | ||
</component> | ||
<component group="org.codehaus.groovy" name="groovy-json" version="3.0.8"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This whole addition should be replaced by us trusting the key for the org.codehaus.groovy
group and cleaning up other entries that reference that key. Note that we have already such a section for a previous key value.
# Conflicts: # build-logic/build-platform/build.gradle.kts
@bot-gradle test and merge |
Your PR is queued. See the queue page for details. |
OK, I've already triggered a build for you. |
And workaround the new bugs.
Specifically: