Skip to content

Conversation

rieske
Copy link
Contributor

@rieske rieske commented Jul 14, 2021

@rieske rieske added the @core Issue owned by GBT Core label Jul 14, 2021
@rieske rieske added this to the 7.2 RC1 milestone Jul 14, 2021
@rieske rieske self-assigned this Jul 14, 2021
Copy link
Member

@ljacomet ljacomet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about the dependency verification changes, otherwise I am OK with the workarounds for Groovy bugs since they affect only test code.

<pgp value="34441e504a937f43eb0daef96a65176a0fb1cd0b"/>
</artifact>
</component>
<component group="org.codehaus.groovy" name="groovy-json" version="3.0.8">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole addition should be replaced by us trusting the key for the org.codehaus.groovy group and cleaning up other entries that reference that key. Note that we have already such a section for a previous key value.

rieske added 2 commits July 14, 2021 17:08
# Conflicts:
#	build-logic/build-platform/build.gradle.kts
@rieske rieske marked this pull request as ready for review July 15, 2021 06:12
@ljacomet ljacomet mentioned this pull request Jul 15, 2021
13 tasks
@rieske
Copy link
Contributor Author

rieske commented Jul 15, 2021

@bot-gradle test and merge

@bot-gradle
Copy link
Collaborator

Your PR is queued. See the queue page for details.

@bot-gradle
Copy link
Collaborator

OK, I've already triggered a build for you.

@bot-gradle bot-gradle merged commit c2d9b07 into master Jul 15, 2021
@rieske rieske deleted the vv/bump-groovy branch July 15, 2021 12:11
@Siedlerchr Siedlerchr mentioned this pull request Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@core Issue owned by GBT Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants