Allow HTTP build cache client requests to be redirected #17390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lptr this is ready for an initial review. At least, the user docs and other documentation will need to be updated. I'll wait until the functionality and API is approved before doing that in another round. |
lptr
reviewed
Jun 16, 2021
...gradle/caching/http/internal/HttpBuildCacheConfigurationBuildOperationIntegrationTest.groovy
Show resolved
Hide resolved
...vy/org/gradle/caching/http/internal/HttpBuildCacheServiceErrorHandlingIntegrationTest.groovy
Outdated
Show resolved
Hide resolved
subprojects/build-cache-http/src/main/java/org/gradle/caching/http/HttpBuildCache.java
Outdated
Show resolved
Hide resolved
...s/build-cache-http/src/main/java/org/gradle/caching/http/internal/HttpBuildCacheService.java
Show resolved
Hide resolved
Co-authored-by: Lóránt Pintér <[email protected]>
|
@lptr Thanks, ready for another round. This is complete, in that I'm not intending to do anymore that isn't in response to review feedback. |
lptr
reviewed
Jun 17, 2021
...vy/org/gradle/caching/http/internal/HttpBuildCacheServiceErrorHandlingIntegrationTest.groovy
Show resolved
Hide resolved
subprojects/docs/src/docs/userguide/build-cache/build_cache.adoc
Outdated
Show resolved
Hide resolved
subprojects/docs/src/docs/userguide/build-cache/build_cache.adoc
Outdated
Show resolved
Hide resolved
subprojects/build-cache-http/src/main/java/org/gradle/caching/http/HttpBuildCache.java
Show resolved
Hide resolved
lptr
approved these changes
Jun 21, 2021
|
OK, I've already triggered a build for you. |
|
Pre-tested commit build failed. |
|
@lptr thanks for the quality review. It made it much better in the end. |
|
failed due to repo.gradle.org outage |
|
@bot-gradle test and merge |
|
OK, I've already triggered a build for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14433
Redirection is always supported, with up to 10 redirects per request.
A new
useExpectContinueconfiguration option has been added that enables use of HTTP expect-continue with store requests, for environments where store requests are routinely redirected and doubly transmitting the cache entry payload is undesirable.