-
Notifications
You must be signed in to change notification settings - Fork 5k
Allow HTTP build cache client requests to be redirected #17390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@lptr this is ready for an initial review. At least, the user docs and other documentation will need to be updated. I'll wait until the functionality and API is approved before doing that in another round. |
lptr
reviewed
Jun 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left a few minor comments.
...gradle/caching/http/internal/HttpBuildCacheConfigurationBuildOperationIntegrationTest.groovy
Show resolved
Hide resolved
...vy/org/gradle/caching/http/internal/HttpBuildCacheServiceErrorHandlingIntegrationTest.groovy
Outdated
Show resolved
Hide resolved
subprojects/build-cache-http/src/main/java/org/gradle/caching/http/HttpBuildCache.java
Outdated
Show resolved
Hide resolved
...s/build-cache-http/src/main/java/org/gradle/caching/http/internal/HttpBuildCacheService.java
Show resolved
Hide resolved
Co-authored-by: Lóránt Pintér <[email protected]>
Fixes #14433
Redirection is always supported, with up to 10 redirects per request.
A new
useExpectContinue
configuration option has been added that enables use of HTTP expect-continue with store requests, for environments where store requests are routinely redirected and doubly transmitting the cache entry payload is undesirable.