Skip to content

Conversation

donat
Copy link
Member

@donat donat commented Apr 7, 2021

This PR implements a first round of cleanup in the org.gradle.util package. It moves classes that not referenced by any external repositories are moved to the org.gradle.util.internal package. The classes not even used internally are deleted.

The external search was done with two tools: Github search (example) and grep.app (example).

Note to the person merging the PR: please don't squash the PR when merging. It will be easier to revert individual changes if we accidentally break an external plugin.

Note to the person reviewing: The PR is rather large, but it's split into tiny individual commits. It's easier to do the review commit-by-commit rather than in one round.

@gradle gradle deleted a comment from donat Apr 7, 2021
@gradle gradle deleted a comment from bot-gradle Apr 7, 2021
@donat donat changed the title Move Resources Move unused classes from org.gradle.util to org.gradle.util.internal package Apr 7, 2021
@donat donat force-pushed the donat/deprecated/unused-util branch from b01a1f8 to c9215b2 Compare April 7, 2021 08:22
@donat donat marked this pull request as ready for review April 7, 2021 08:31
@donat donat requested a review from rieske April 7, 2021 08:31
@donat donat requested a review from rieske April 7, 2021 09:23
@gradle gradle deleted a comment from donat Apr 7, 2021
@gradle gradle deleted a comment from donat Apr 9, 2021
@gradle gradle deleted a comment from bot-gradle Apr 9, 2021
@donat
Copy link
Member Author

donat commented Apr 9, 2021

@bot-gradle test and merge this

@bot-gradle
Copy link
Collaborator

Your PR is queued because #16736 is being built.

@donat
Copy link
Member Author

donat commented Apr 9, 2021

@bot-gradle test and merge this

@gradle gradle deleted a comment from donat Apr 9, 2021
@bot-gradle
Copy link
Collaborator

OK, I've already triggered a build for you.

@bot-gradle bot-gradle merged commit 8a91a2f into master Apr 9, 2021
@donat donat deleted the donat/deprecated/unused-util branch June 16, 2021 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants