-
Notifications
You must be signed in to change notification settings - Fork 5k
Move unused classes from org.gradle.util to org.gradle.util.internal package #16727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b01a1f8
to
c9215b2
Compare
rieske
reviewed
Apr 7, 2021
subprojects/docs/src/docs/userguide/migration/upgrading_version_7.adoc
Outdated
Show resolved
Hide resolved
rieske
approved these changes
Apr 7, 2021
@bot-gradle test and merge this |
Your PR is queued because #16736 is being built. |
@bot-gradle test and merge this |
OK, I've already triggered a build for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a first round of cleanup in the
org.gradle.util
package. It moves classes that not referenced by any external repositories are moved to theorg.gradle.util.internal
package. The classes not even used internally are deleted.The external search was done with two tools: Github search (example) and grep.app (example).
Note to the person merging the PR: please don't squash the PR when merging. It will be easier to revert individual changes if we accidentally break an external plugin.
Note to the person reviewing: The PR is rather large, but it's split into tiny individual commits. It's easier to do the review commit-by-commit rather than in one round.