Include Kotlin DSL samples in wrapper chapter #6434
Conversation
There was a problem hiding this comment.
❌ Given that it's currently not possible to use named here getByName will do. I would encourage the use of the block version though since it allows for evolving the task configuration more naturally:
tasks.getByName<Wrapper>("wrapper") {
distributionType = Wrapper.DistributionType.ALL
}There was a problem hiding this comment.
Updated. Want to look again when you have a moment? Is this otherwise merge-able?
There was a problem hiding this comment.
Yes you are right, that make more sense @bamboo.
Especially for new Gradle users its way more understandable 👍
Signed-off-by: StefMa <[email protected]>
Signed-off-by: StefMa <[email protected]>
e6e49ff to
44aa4f1
Compare
| executable: gradle | ||
| args: tasks | ||
| commands: [{ | ||
| execution-subdirectory: groovy |
There was a problem hiding this comment.
Could you pls explain this configuration to me?
I assume that these are GradleRunner parameters, right?
But where will these be used?
There was a problem hiding this comment.
We have a tool called Exemplar (to be open-sourced soon) that is configured to execute these samples through configuration in these files.
Basically, it looks for all .sample.conf files and executes what's inside using TestKit
Context
This builds upon @StefMa's PR to convert the wrapper user manual doc to include Kotlin DSL samples and test them.
Passing branch build
Gradle Core Team Checklist