Include Kotlin DSL samples in wrapper chapter #6434
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
bamboo
requested changes
Aug 20, 2018
There was a problem hiding this comment.
❌ Given that it's currently not possible to use named here getByName will do. I would encourage the use of the block version though since it allows for evolving the task configuration more naturally:
tasks.getByName<Wrapper>("wrapper") {
distributionType = Wrapper.DistributionType.ALL
}There was a problem hiding this comment.
Updated. Want to look again when you have a moment? Is this otherwise merge-able?
There was a problem hiding this comment.
Yes you are right, that make more sense @bamboo.
Especially for new Gradle users its way more understandable 👍
Signed-off-by: StefMa <[email protected]>
Signed-off-by: StefMa <[email protected]>
e6e49ff to
44aa4f1
Compare
8 tasks
StefMa
approved these changes
Aug 21, 2018
Context
This builds upon @StefMa's PR to convert the wrapper user manual doc to include Kotlin DSL samples and test them.
Passing branch build
Gradle Core Team Checklist