Skip to content

Conversation

armgit5
Copy link

@armgit5 armgit5 commented Nov 23, 2018

Added examples as middleware functions to upload a single file or multiple files.
Added missing json key file in Stroge constructor.
Cleaned up links by changing long links to embedded links in sentences.

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

adding key file in Storage constructor and step by step how to get the key file
Examples as middleware functions to upload a single file or multiple files.
Changed long links to embedded links in sentences.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Nov 23, 2018
@armgit5
Copy link
Author

armgit5 commented Nov 27, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 27, 2018
@jkwlui jkwlui added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 28, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 28, 2018
@jkwlui jkwlui added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 28, 2018
@jkwlui
Copy link
Member

jkwlui commented Nov 28, 2018

Hi @armgit5, thank you for sharing your experience with setting up Cloud Storage with Express, that's really helpful to a lot of folks out there since it's such a popular framework.

We don't usually host specific use cases on the README.md file of the library - @fhinkel, what's a better place to host solutions by contributors?

@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 28, 2018
@armgit5
Copy link
Author

armgit5 commented