Skip to content

Conversation

armgit5
Copy link

@armgit5 armgit5 commented Nov 23, 2018

Added examples as middleware functions to upload a single file or multiple files.
Added missing json key file in Stroge constructor.
Cleaned up links by changing long links to embedded links in sentences.

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

adding key file in Storage constructor and step by step how to get the key file
Examples as middleware functions to upload a single file or multiple files.
Changed long links to embedded links in sentences.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Nov 23, 2018
@armgit5
Copy link
Author

armgit5 commented Nov 27, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 27, 2018
@jkwlui jkwlui added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 28, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 28, 2018
@jkwlui jkwlui added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 28, 2018
@jkwlui
Copy link
Member

jkwlui commented Nov 28, 2018

Hi @armgit5, thank you for sharing your experience with setting up Cloud Storage with Express, that's really helpful to a lot of folks out there since it's such a popular framework.

We don't usually host specific use cases on the README.md file of the library - @fhinkel, what's a better place to host solutions by contributors?

@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 28, 2018
@armgit5
Copy link
Author

armgit5 commented Nov 28, 2018

Thank you for your reply, @kinwa91. Please let me know if there is any place I could contribute and share some examples I've been using for my project. I really think it'd be very helpful to others :-) really like your google cloud solutions :-)

@JustinBeckwith
Copy link
Contributor

Apologies for the delay on this one. And thank you so much! The best way to add a sample is to create a new *.js file in the samples directory, similar to the others already in there. That way, we can add tests to make sure the samples don't break over time. If you'd be willing to do this - we'd really appreciate it!

@fhinkel
Copy link
Contributor

fhinkel commented Dec 21, 2018

Hi, thanks for the PR! This would be the right place, would you be willing to wrap it in a tutorial?

@armgit5
Copy link
Author

armgit5 commented Jan 2, 2019

Happy New Year 2019 to you all, I wouldn't mind that at all, would really be happy to do it :-)

@JustinBeckwith
Copy link
Contributor

Thanks again @armgit5! If you need any help submitting the community tutorial - please do let us know!

@armgit5
Copy link
Author

armgit5 commented Jan 29, 2019

I'm sorry it takes me a long time, I still want to put those tutorial still. I will definitely come back to you again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants