chore: Making automated version updates in readme.md #9150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suztomo
reviewed
Feb 23, 2023
generation/readme_update.sh
Outdated
| for module in $(find . -mindepth 2 -maxdepth 2 -name pom.xml | sort | xargs dirname); do | ||
|
|
||
| if [[ "${module}" = *java-core ]] || [[ "${module}" = *java-shared-dependencies ]] || [[ "${module}" = *java-iam ]]; then | ||
| continue |
generation/readme_update.sh
Outdated
|
|
||
| readme_file="${module}/README.md" | ||
|
|
||
| if [ -e ${module}/README.md ]; then |
generation/readme_update.sh
Outdated
| @@ -0,0 +1,38 @@ | |||
| #!/bin/bash | |||
|
|
|||
| config_line="" | |||
suztomo
reviewed
Feb 23, 2023
suztomo
reviewed
Feb 23, 2023
generation/readme_update.sh
Outdated
|
|
||
| for module in $(find . -mindepth 2 -maxdepth 2 -name pom.xml | sort | xargs dirname); do | ||
|
|
||
| if [[ "${module}" = *java-core ]] || [[ "${module}" = *java-shared-dependencies ]] || [[ "${module}" = *java-iam ]]; then |
There was a problem hiding this comment.
Should java-iam be excluded? If so, can you add source code comment why?
There was a problem hiding this comment.
I don't think it should have been excluded. I've added it back again, along with necessary changes in its readme.
suztomo
reviewed
Feb 23, 2023
generation/readme_update.sh
Outdated
| line_number_end=$(grep -n -m 1 "Scala" ${readme_file} | sed 's/\([0-9]*\).*/\1/') | ||
| end_line=${line_number_end}+4 | ||
|
|
||
| start_line_append="<!--- {x-version-update-start:${artifactId}:released} -->" |
There was a problem hiding this comment.
Suggested change
| start_line_append="<!--- {x-version-update-start:${artifactId}:released} -->" | |
| start_line_append="<!-- {x-version-update-start:${artifactId}:released} -->" |
I believe it's unnecessary.
There was a problem hiding this comment.
yeah, it works either way.
There was a problem hiding this comment.
Yes, it works but unnecessary. Let's not to have unnecessary characters.
suztomo
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 2 things:
readme_update.shscript which is responsible for adding annotations in all the valid readme.md files.Later on I will introduce how to use libraries-bom in all the readme's, along with automated version updates for it.