Skip to content

chore: Making automated version updates in readme.md #9150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 28, 2023
Merged

chore: Making automated version updates in readme.md #9150

merged 6 commits into from
Feb 28, 2023

Conversation

ddixit14
Copy link
Contributor

@ddixit14 ddixit14 commented Feb 23, 2023 •
edited
Loading

This PR does 2 things:

  1. Adding readme_update.sh script which is responsible for adding annotations in all the valid readme.md files.
  2. After running the script, all the readme.md's have annotations in them, except a few modules.

Later on I will introduce how to use libraries-bom in all the readme's, along with automated version updates for it.

@ddixit14 ddixit14 requested a review from suztomo February 23, 2023 15:56
suztomo
suztomo reviewed Feb 23, 2023
View reviewed changes
generation/readme_update.sh Outdated
for module in $(find . -mindepth 2 -maxdepth 2 -name pom.xml | sort | xargs dirname); do

if [[ "${module}" = *java-core ]] || [[ "${module}" = *java-shared-dependencies ]] || [[ "${module}" = *java-iam ]]; then
continue
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

generation/readme_update.sh Outdated

readme_file="${module}/README.md"

if [ -e ${module}/README.md ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

generation/readme_update.sh Outdated
@@ -0,0 +1,38 @@
#!/bin/bash

config_line=""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, removed now.