Skip to content

Configurable polyfills (including automatic tool call example), group inputs in struct, add strftime_now support #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ochafik merged 22 commits into from
Feb 4, 2025
Merged

Configurable polyfills (including automatic tool call example), group inputs in struct, add strftime_now support #46

ochafik merged 22 commits into from
Feb 4, 2025

Conversation

@ochafik
Copy link
Contributor

@ochafik ochafik commented Feb 3, 2025 •
edited
Loading

This is to prepare support for DeepSeek R1 in llama.cpp: ggml-org/llama.cpp#11607

  • chat_template::apply now takes inputs + options
  • Can disable all polyfills or each of them separately
  • Added automatic tool call example using the delta of two calls
  • Bit more defensive code around iterable types
  • Renamed test scripts

ochafik added 17 commits February 1, 2025 11:39
TMP inputs refactor
6b9a34b
Tool support backfil: provide automated tool call example
4d64819
Switch naming towards polyfills (and skip tool-related logic if there…
0026057 
…'s no tools)
rename test-chat-template -> test-supported-template
23f4378
refactor fetch_templates_and_goldens
51c5ac5
print test command in format pastable to vscode debugger
876fecb
Update chat-template.hpp
53fabdd
Merge branch 'main' into tool-backfill
f6f85e9
Merge branch 'inputs' into tool-backfill
b1d0d56
fix compilation
fb7a3b3
implement strftime_now + respect new opts
354e77a
more defensive against non arrays in reject/accept + fix test builtin…
a6a5cba 
…_tools
rename test script
f74b40d
more type defensiveness
a10a911
fix json typo
968ea9f
Update tools prompt
16664ae
expose all polyfills as options
01bc7f3
@ochafik ochafik changed the title Configurable polyfill (including automatic tool call example), group inputs in struct, add strftime_now support Configurable polyfills (including automatic tool call example), group inputs in struct, add strftime_now support Feb 3, 2025
ochafik pushed a commit to ochafik/llama.cpp that referenced this pull request Feb 3, 2025
sync: minja google/minja#46
108da90
@ochafik ochafik merged commit 182de30 into main Feb 4, 2025
11 checks passed
@ochafik ochafik deleted the tool-backfill branch February 4, 2025 03:46
This was referenced Feb 4, 2025
Merged
Merged
ochafik added a commit to ggml-org/llama.cpp that referenced this pull request Feb 5, 2025
@ochafik
sync: minja (#11641)
9f4cc8f 
* `sync`: minja

google/minja@182de30

google/minja#46

google/minja#45
orca-zhang pushed a commit to orca-zhang/llama.cpp that referenced this pull request Feb 26, 2025
@ochafik @orca-zhang
sync: minja (ggml-org#11641)
9205f59 
* `sync`: minja

google/minja@182de30

google/minja#46

google/minja#45
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Feb 26, 2025
@ochafik @NeoZhangJianyu
sync: minja (ggml-org#11641)
b1d71c7 
* `sync`: minja

google/minja@182de30

google/minja#46

google/minja#45
justinryan-0923 pushed a commit to justinryan-0923/llama.cpp that referenced this pull request May 30, 2025
@ochafik
sync: minja (#11641)
0bd9e2b 
* `sync`: minja

google/minja@182de30

google/minja#46

google/minja#45
ochafik added a commit to ochafik/minja that referenced this pull request Nov 2, 2025
@ochafik
Merge pull request google#46 from google/tool-backfill
36d0d73 
Configurable polyfills (including automatic tool call example), group inputs in struct, add strftime_now support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ochafik