Fix multiline comments (. isn't multiline, need [\s\S\r\n]) #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ochafik
added a commit
to ggml-org/llama.cpp
that referenced
this pull request
Feb 5, 2025
* `sync`: minja google/minja@182de30 google/minja#46 google/minja#45
orca-zhang
pushed a commit
to orca-zhang/llama.cpp
that referenced
this pull request
Feb 26, 2025
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Feb 26, 2025
justinryan-0923
pushed a commit
to justinryan-0923/llama.cpp
that referenced
this pull request
May 30, 2025
* `sync`: minja google/minja@182de30 google/minja#46 google/minja#45
ochafik
added a commit
to ochafik/minja
that referenced
this pull request
Nov 2, 2025
Fix multiline comments (. isn't multiline, need [\s\S\r\n])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ericcurtin sorry, finally got to look into it. Hopefully this does the trick, should be a simpler fix than #37