Skip to content

Add support for listing and getting repository/organization webhook deliveries #1934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmlewis merged 15 commits into from
Jul 13, 2021
+853 −2
Merged

Add support for listing and getting repository/organization webhook deliveries #1934

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
54e5502
Add support for listing and getting repository webhook deliveries
mumoshu Jul 3, 2021
f5889f8
Add test for HookDelivery.ParseRequestPayload
mumoshu Jul 6, 2021
f6d688a
Restructure populatePageValues to reduce nesting
mumoshu Jul 6, 2021
ff5a47a
Use Timestamp instead of time.Time for delivered_at
mumoshu Jul 6, 2021
dffbb1c
Fix HookResponse.Header to Headers for consistency with the underlyin…
mumoshu Jul 6, 2021
5f0e1e4
Use %v instead of %d for formatting int64
mumoshu Jul 6, 2021
431c77c
Add more tests for ParseRequestPayload
mumoshu Jul 6, 2021
23922a8
Enhance cursor pagination test for more coverage
mumoshu Jul 6, 2021
72c3380
Make it clear that cursor and page are mutually exclusive
mumoshu Jul 8, 2021
5b86aff
Add periods to field comments
mumoshu Jul 8, 2021
194eff6
Add comments on HookRequest and HookResponse
mumoshu Jul 8, 2021
1381c0f
Accept suggestions from gmlewis with thanks :)
mumoshu Jul 9, 2021
0a3739c
Add support for listing and getting organization webhook deliveries
mumoshu Jul 11, 2021
fc8d20f
Add copyright notice to orgs_hooks_deliveries.go
mumoshu Jul 12, 2021
123bafa
Add blank after if err block for consistency
mumoshu Jul 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Enhance cursor pagination test for more coverage
  • Loading branch information
@mumoshu
mumoshu committed Jul 6, 2021
commit 23922a838e3b17c930068442afd23185e878216c
14 changes: 14 additions & 0 deletions github/github_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,6 +635,20 @@ func TestResponse_cursorPagination(t *testing.T) {
if got, want := response.NextPageToken, "url-encoded-next-page-token"; want != got {
t.Errorf("response.NextPageToken: %v, want %v", got, want)
}

// cursor-based pagination with "cursor" param
r = http.Response{
Header: http.Header{
"Link": {
`<https://api.github.com/?cursor=v1_12345678>; rel="next"`,
},
},
}

response = newResponse(&r)
if got, want := response.Cursor, "v1_12345678"; got != want {
t.Errorf("response.Cursor: %v, want %v", got, want)
}
}

func TestResponse_populatePageValues_invalid(t *testing.T) {
Expand Down