Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add support for listing and getting organization webhook deliveries
Ref #1933
  • Loading branch information
mumoshu committed Jul 11, 2021
commit 0a3739c94ba1eb5fe9f040f465b1e5387eb802e1
48 changes: 48 additions & 0 deletions github/orgs_hooks_deliveries.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
package github

import (
"context"
"fmt"
)

// ListHookDeliveries lists webhook deliveries for a webhook configured in an organization.
//
// GitHub API docs: https://docs.github.com/en/rest/reference/orgs#list-deliveries-for-an-organization-webhook
func (s *OrganizationsService) ListHookDeliveries(ctx context.Context, org string, id int64, opts *ListCursorOptions) ([]*HookDelivery, *Response, error) {
u := fmt.Sprintf("orgs/%v/hooks/%v/deliveries", org, id)
u, err := addOptions(u, opts)
if err != nil {
return nil, nil, err
}

req, err := s.client.NewRequest("GET", u, nil)
if err != nil {
return nil, nil, err
}

deliveries := []*HookDelivery{}
resp, err := s.client.Do(ctx, req, &deliveries)
if err != nil {
return nil, resp, err
}

return deliveries, resp, nil
}

// GetHookDelivery returns a delivery for a webhook configured in an organization.
//
// GitHub API docs: https://docs.github.com/en/rest/reference/orgs#get-a-webhook-delivery-for-an-organization-webhook
func (s *OrganizationsService) GetHookDelivery(ctx context.Context, owner string, hookID, deliveryID int64) (*HookDelivery, *Response, error) {
u := fmt.Sprintf("orgs/%v/hooks/%v/deliveries/%v", owner, hookID, deliveryID)
req, err := s.client.NewRequest("GET", u, nil)
if err != nil {
return nil, nil, err
}
h := new(HookDelivery)
resp, err := s.client.Do(ctx, req, h)
if err != nil {
return nil, resp, err
}

return h, resp, nil
}
106 changes: 106 additions & 0 deletions github/orgs_hooks_deliveries_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,106 @@
// Copyright 2021 The go-github AUTHORS. All rights reserved.
//
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

package github

import (
"context"
"fmt"
"net/http"
"testing"

"github.com/google/go-cmp/cmp"
)

func TestOrganizationsService_ListHookDeliveries(t *testing.T) {
client, mux, _, teardown := setup()
defer teardown()

mux.HandleFunc("/orgs/o/hooks/1/deliveries", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "GET")
testFormValues(t, r, values{"cursor": "v1_12077215967"})
fmt.Fprint(w, `[{"id":1}, {"id":2}]`)
})

opt := &ListCursorOptions{Cursor: "v1_12077215967"}

ctx := context.Background()
hooks, _, err := client.Organizations.ListHookDeliveries(ctx, "o", 1, opt)
if err != nil {
t.Errorf("Organizations.ListHookDeliveries returned error: %v", err)
}

want := []*HookDelivery{{ID: Int64(1)}, {ID: Int64(2)}}
if d := cmp.Diff(hooks, want); d != "" {
t.Errorf("Organizations.ListHooks want (-), got (+):\n%s", d)
}

const methodName = "ListHookDeliveries"
testBadOptions(t, methodName, func() (err error) {
_, _, err = client.Organizations.ListHookDeliveries(ctx, "\n", -1, opt)
return err
})

testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) {
got, resp, err := client.Organizations.ListHookDeliveries(ctx, "o", 1, opt)
if got != nil {
t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got)
}
return resp, err
})
}

func TestOrganizationsService_ListHookDeliveries_invalidOwner(t *testing.T) {
client, _, _, teardown := setup()
defer teardown()

ctx := context.Background()
_, _, err := client.Organizations.ListHookDeliveries(ctx, "%", 1, nil)
testURLParseError(t, err)
}

func TestOrganizationsService_GetHookDelivery(t *testing.T) {
client, mux, _, teardown := setup()
defer teardown()

mux.HandleFunc("/orgs/o/hooks/1/deliveries/1", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "GET")
fmt.Fprint(w, `{"id":1}`)
})

ctx := context.Background()
hook, _, err := client.Organizations.GetHookDelivery(ctx, "o", 1, 1)
if err != nil {
t.Errorf("Organizations.GetHookDelivery returned error: %v", err)
}

want := &HookDelivery{ID: Int64(1)}
if !cmp.Equal(hook, want) {
t.Errorf("Organizations.GetHookDelivery returned %+v, want %+v", hook, want)
}

const methodName = "GetHookDelivery"
testBadOptions(t, methodName, func() (err error) {
_, _, err = client.Organizations.GetHookDelivery(ctx, "\n", -1, -1)
return err
})

testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) {
got, resp, err := client.Organizations.GetHookDelivery(ctx, "o", 1, 1)
if got != nil {
t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got)
}
return resp, err
})
}

func TestOrganizationsService_GetHookDelivery_invalidOwner(t *testing.T) {
client, _, _, teardown := setup()
defer teardown()

ctx := context.Background()
_, _, err := client.Organizations.GetHookDelivery(ctx, "%", 1, 1)
testURLParseError(t, err)
}