Skip to content

Address issue #277 #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Address issue #277 #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8a6d9f4
Added bson options.
Mar 29, 2017
6572daf
Triger CI.
Mar 29, 2017
2ded4cd
Call Get/SetExtension correctly.
Mar 29, 2017
a84ce6f
Fix string contact.
Mar 29, 2017
82c44f8
Fix passed in function type.
Mar 29, 2017
1880fdd
Fix GetExtension.
Mar 29, 2017
3c01a77
Quote.
Mar 29, 2017
f15167c
Remove extra space.
Mar 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions protoc-gen-gogofast/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ func main() {
vanity.ForEachFile(files, vanity.TurnOnMarshalerAll)
vanity.ForEachFile(files, vanity.TurnOnSizerAll)
vanity.ForEachFile(files, vanity.TurnOnUnmarshalerAll)
vanity.ForEachFieldInFiles(files, vanity.SetBsonTagFieldOption)

resp := command.Generate(req)
command.Write(resp)
Expand Down
13 changes: 13 additions & 0 deletions vanity/field.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,3 +81,16 @@ func TurnOffNullableForNativeTypesWithoutDefaultsOnly(field *descriptor.FieldDes
}
SetBoolFieldOption(gogoproto.E_Nullable, false)(field)
}

func SetBsonTagFieldOption(field *descriptor.FieldDescriptorProto) {
if field.Options == nil {
field.Options = &descriptor.FieldOptions{}
}
value := "bson:\"" + *field.Name + ",omitempty\""
if v, err := proto.GetExtension(field.Options, gogoproto.E_Moretags); err == nil {
value = v.(string) + " " + value
}
if err := proto.SetExtension(field.Options, gogoproto.E_Moretags, &value); err != nil {
panic(err)
}
}