Skip to content

Conversation

lnshi
Copy link

@lnshi lnshi commented Mar 29, 2017

No description provided.

@awalterschulze
Copy link
Member

So the idea is that you create this as your own vanity binary in your own repo.
Its kind of hard to decide which vanity binaries to create and what combination of options they will contain. For example lots of people don't use bson. But if you create your own binary then you have the freedom to do exactly what you want. And it should be pretty easy to maintain. I mean there is no reason why this cannot all live in one main.go file that simply imports gogoprotobuf.

@lnshi
Copy link
Author

lnshi commented Mar 29, 2017

Ah, sorry, I guess I just spammed ur email, sorry, I am gonna close this. Just because I found if I want to run the tests against my fork, I need to change lots of import paths...

Understand, but can we consider to make this a command option? so people can choose there....

@lnshi
Copy link
Author

lnshi commented Mar 29, 2017

And @awalterschulze, can u do me a bit more favour, I just cannot figure out why the last test sets always fails, checked the logs, just cannot find helpful info...

What does this mean?

The command "if [ "$TRAVIS_GO_VERSION" == 1.8 ] && [[ "$PROTOBUF_VERSION" == 3.1.0 ]]; then ! git status --porcelain | read || (git status; git diff; exit 1); fi" exited with 1.

@lnshi lnshi closed this Mar 29, 2017
@awalterschulze
Copy link
Member

awalterschulze commented Mar 29, 2017

govet is saying the struct tag's syntax is broken, but I can't spot the problem

test/fuzztests/fuzz.pb.go:50: struct field tag `protobuf:"fixed64,1,rep,packed,name=Field1,json=field1" json:"Field1,omitempty" bson: "Field1,omitempty"` not compatible with reflect.StructTag.Get: bad syntax for struct tag value

And then you just need to regenerate all the code, make regenerate for protoc 3.1.0

@awalterschulze
Copy link
Member

At some point you are going to need your own test setup :)

@awalterschulze
Copy link
Member

That bash if means that only for go 1.8 and protoc 3.1.0 make sure that the generated code is the code that is check it by doing a git diff after the code has been regenerated.

@awalterschulze
Copy link
Member

I am can put a link from my documentation to your protoc binary on github for people who want bson encoding. What do you think?

@lnshi
Copy link
Author

lnshi commented Mar 30, 2017

@awalterschulze how come only for that test case there is one extra space coming after the bson:

@awalterschulze
Copy link
Member

Which test are we talking about?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants