Avoid warning about __TIME__ in non-test builds #4966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #ifdef STATIC_RANDOM_TESTS | ||
| inline consteval uint32_t CxPRNG(int16_t n = counter_val, std::array<char, 9> seed = std::array<char, 9>{__TIME__}) { | ||
| #else | ||
| inline consteval uint32_t CxPRNG(int16_t n = counter_val, std::array<char, 9> seed = std::array<char, 9>{"12:34:56"}) { |
There was a problem hiding this comment.
__TIME__ also appears on line 70 / 74
|
Does the new #define default off / not defined? Would it make sense to set it in |
Yes, it looks reasonable. |
vincele
reviewed
Mar 15, 2025
| } | ||
| inline consteval int32_t RandIntCx(const int32_t min, const int32_t max, const int16_t n, | ||
| const std::array<char, 9> seed = std::array<char, 9>{__TIME__}) noexcept | ||
| #ifdef STATIC_RANDOM_TESTS |
There was a problem hiding this comment.
why not using a #define TEST_TIME_SEED [...] to avoid putting ifdef multiple times in the source code ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could be a way to fix #4811