feat(copyright): Use package based dependency for json #1226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1193be1 to
007608d
Compare
|
appreciate this commit, but I did some testing on 3.4.0 rc1 already to make sure it is working. I am not so sure about adding this on short final. maybe tests fail because of timing issues of course. |
007608d to
44174aa
Compare
44174aa to
ac4b31a
Compare
|
The tests are now fixed. Can you please check again? |
|
(from discussion) let#s compare output of copyright with open ssl for external dependency and package dependency. |
|
(from discussion:) better to use the c++ lib instead of the c one |
|
Found And can be enabled in CentOS 7 using EPEL. |
9d88168 to
bdf28f9
Compare
ag4ums
reviewed
Oct 30, 2018
|
Tested on Ubuntu 18.04 and CentOS 7 |
5ac724c to
3639e51
Compare
|
Compilation failed on Fedora 27 and fixed accordingly. |
Remove dependency from external file for json-hpp and shift to packaged based dependency (libjsoncpp from Debian based and jsoncpp from RedHat based systems). (Since library is changed, no need to check GCC version) Signed-off-by: Gaurav Mishra <[email protected]>
Since json library is not independent of C++ version, the macro DISABLE_JSON is no longer required. Signed-off-by: Gaurav Mishra <[email protected]>
3639e51 to
0ce85bd
Compare
|
tested again with u1604: works |
mcjaeger
approved these changes
Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove dependency from external file download for json-hpp and shift to packaged based dependency (
libjsoncppfrom Debian based andjsoncppfrom RedHat based systems).Changes
jsoncpppackage dependency.How to test
Compile the
copyrightpackage in Debian and RedHat based systems and check the JSON output.$ sudo ./utils/fo-installdeps -ye $ make copyright $ cd src/copyright/agent $ ./copyright -J ./copyright.ccCloses #1084