Skip to content

Improve json hpp install #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Improve json hpp install #1199

wants to merge 7 commits into from

Conversation

NicolasToussaint
Copy link
Member

Description

I have several difficulties when installing Fossology from sources:

  • sometimes my network is unstable, and the whole install process fails because the download of the json.hpp file fails
  • Quite often, the machines I install Fossology on require a proxy to access the internet.

Changes

  • Check first that file final file is not already available (sith correct checksum)
  • Added the Retry and Timeout options to curl, to make the installation process more robust
  • Let the user configure a proxy by sourcing a new configuration file: /etc/fossology/fossology-proxy.conf

How to test

Install Fossology from source, through a proxy

@NicolasToussaint
fix(install-json-hpp.sh) make json-hpp download more robust to networ…
cc23278 
…k errors:

- do not download file if already available
- use curl retry options
- show proper error if download failed

Signed-off-by: Toussaint Nicolas <[email protected]>
@NicolasToussaint
fix(install-json-hpp.sh) Read proxy config from new configuration file
9e477bc 
(/etc/fossology/fossology-proxy.conf)

Signed-off-by: Toussaint Nicolas <[email protected]>
@ghost ghost added the needs code review label Sep 4, 2018
GMishx
GMishx requested changes Sep 5, 2018
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider making the changes

GMishx
GMishx reviewed Sep 5, 2018
View reviewed changes
GMishx
GMishx reviewed Sep 5, 2018
View reviewed changes
@NicolasToussaint
fix(install-json-hpp.sh) Also fix version URL
6efa4c4 
Signed-off-by: Toussaint Nicolas <[email protected]>
@NicolasToussaint
fix(install-json-hpp.sh) Removing proxy configuration,
5443841 
not as straight forward as initially thought

Signed-off-by: Toussaint Nicolas <[email protected]>
@GMishx GMishx added the WIP label Sep 10, 2018
@GMishx
Copy link
Member

GMishx commented Nov 1, 2018

Done with an alternative approach here #1226

@ag4ums
Copy link
Contributor

ag4ums commented Nov 1, 2018

the fix is here #1226 so closing this.

@ag4ums ag4ums closed this Nov 1, 2018
@ghost ghost removed the needs code review label Nov 1, 2018
@NicolasToussaint NicolasToussaint deleted the improve-json-hpp-install branch November 5, 2018 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GMishx GMishx GMishx requested changes

Assignees

No one assigned

Labels

WIP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NicolasToussaint @GMishx @ag4ums