-
Notifications
You must be signed in to change notification settings - Fork 483
feat(copyright): also show deactivated copyrights/urls/authors/... in the UI #906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(copyright): also show deactivated copyrights/urls/authors/... in the UI #906
Conversation
5d26799
to
58821cd
Compare
58821cd
to
6cb3192
Compare
@mcjaeger This PR contains now the discussed changes to the headers of the tables. |
@maxhbr so, I tested it: activtation, deactivation in aggregated and single file works and can be seen in the generated readme oss output. But ... adding text findings manually is not supported by this PR, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Looks Good
This PR adds a new table with deactivated statements to all views of Copyright, the result looks like:
and
To make the

Email/URL/Author
more readable this adds tabs which look like:(there is a slight css problem, i.e. the
Undo
is black and not blue. That will be fixed by #904)