Skip to content

Conversation

maxhbr
Copy link
Member

@maxhbr maxhbr commented Sep 12, 2017

This PR adds a new table with deactivated statements to all views of Copyright, the result looks like:

2017-09-12_07 53 59
and
2017-09-12_07 53 50

To make the Email/URL/Author more readable this adds tabs which look like:
2017-09-12_07 53 43
(there is a slight css problem, i.e. the Undo is black and not blue. That will be fixed by #904)

@maxhbr maxhbr force-pushed the feat/copyrightShouldDisplayDeactivatedEntries branch from 5d26799 to 58821cd Compare September 12, 2017 06:59
@maxhbr maxhbr force-pushed the feat/copyrightShouldDisplayDeactivatedEntries branch from 58821cd to 6cb3192 Compare September 12, 2017 12:42
@maxhbr
Copy link
Member Author

maxhbr commented Sep 12, 2017

@mcjaeger This PR contains now the discussed changes to the headers of the tables.

@mcjaeger mcjaeger self-assigned this Sep 12, 2017
maxhbr added a commit to maxhbr/fossology that referenced this pull request Sep 25, 2017
maxhbr added a commit to maxhbr/fossology that referenced this pull request Sep 25, 2017
maxhbr added a commit to maxhbr/fossology that referenced this pull request Sep 25, 2017
maxhbr added a commit to maxhbr/fossology that referenced this pull request Sep 25, 2017
maxhbr added a commit to maxhbr/fossology that referenced this pull request Sep 25, 2017
maxhbr added a commit to maxhbr/fossology that referenced this pull request Sep 25, 2017
maxhbr added a commit to maxhbr/fossology that referenced this pull request Sep 25, 2017
maxhbr added a commit to maxhbr/fossology that referenced this pull request Sep 25, 2017
maxhbr added a commit to maxhbr/fossology that referenced this pull request Sep 27, 2017
maxhbr added a commit to maxhbr/fossology that referenced this pull request Sep 27, 2017
maxhbr added a commit to maxhbr/fossology that referenced this pull request Sep 27, 2017
maxhbr added a commit to maxhbr/fossology that referenced this pull request Sep 29, 2017
maxhbr added a commit to maxhbr/fossology that referenced this pull request Sep 29, 2017
@mcjaeger
Copy link
Member

mcjaeger commented Oct 2, 2017

@maxhbr so, I tested it: activtation, deactivation in aggregated and single file works and can be seen in the generated readme oss output. But ... adding text findings manually is not supported by this PR, right?

@mcjaeger mcjaeger removed their assignment Oct 3, 2017
Copy link
Member

@shaheemazmalmmd shaheemazmalmmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Looks Good

@mcjaeger mcjaeger changed the title feat(copyright): also show deactivated copyrights/urls/autohrs/... in the UI feat(copyright): also show deactivated copyrights/urls/authors/... in the UI Oct 13, 2017
@mcjaeger mcjaeger merged commit 9b9f676 into fossology:master Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants