fix(php): resolve pass-by-reference errors #893
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seeing these in the build log: Only variables should be passed by reference /home/travis/build/fossology/fossology/src/lib/php/Test/TestPgDb.php:62 /home/travis/build/fossology/fossology/src/lib/php/Test/TestLiteDb.php:66 This PR resolves those errors squash
792f246 to
08d1add
Compare
|
This fix is already contained in #857 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing these in the Travis build logs (job 16):
This causes 181 errors to occur in this job. This fix resolves all errors so that the job succeeds again.
EDIT: this is for the PHP7 build job. Only test files are changed so no production functionality is affected.