fix(debian9): add compatibility with debian9 #857

max-wittig · 2017-06-21T12:32:36Z

Maybe also works for ubuntu 16.04+, but not tested!

Why tests were touched: Only variables should be passed by reference
Updated default PHP Unit as Fossology doesn't support PHP 5.4 anyway
Removed PHP 5.4 from travis-ci for the same reason

max-wittig · 2017-06-23T08:26:23Z

Some issues exist with permissions on debian 8 with this PR, which is weird because I didn't even touch any file permissions

maxhbr · 2017-07-12T08:59:47Z

src/testing/docker/default-docker-test.sh


 #### fossology needs up to 15 seconds to startup
-sleep 15
+sleep 30


please update or remove the comment above

maxhbr

The test default-docker-test.sh does no longer test whether fossology is running.

maxhbr · 2017-07-12T09:01:26Z

src/testing/docker/default-docker-test.sh


 #### is fossology reachable? --> check title
-curl -L -s http://172.18.0.22/repo/ | grep -q "<title>Getting Started with FOSSology</title>"
+curl -v -L -s http://172.18.0.22 | grep -q "<title>Apache2 Debian Default Page: It works</title>"


This test is no longer checking that fossology is running or responding! Please add also the old test back in.

Nice find. I just disabled that temporary for testing, but nearly forgot to add it back in. Thanks!

maxhbr · 2017-07-17T11:56:58Z

utils/fo-installdeps

              jessie) apt-get $YesOpt install postgresql-server-dev-9.4;;
-              xenial) apt-get $YesOpt install postgresql-server-dev-9.5;;
+              xenial|yakkety) apt-get $YesOpt install postgresql-server-dev-9.5;;
+              stretch|buster|sid|zesty|artful) apt-get $YesOpt install postgresql-server-dev-9.6;;


~~For the moving target sid it might be good to reference a package without a version, e.g. postgresql-server-dev-all.~~ that will bring hidden problems. A failing apt-get install is the better choice.

So it's okay, if I understand that correctly?

it will break soon and is the same problem as in #864. Maybe it is a good idea to remove the sid option but I am not sure.
=> It is OK until someone finds a better solution.

IMHO it is reasonable to remove 'sid' support - as a bleeding edge unstable 'rolling' distro, much like arch, users are expected to "know what they are doing" - and for the same reason arch support was deemed to be not a priority, it is probably an extremely small use-case that anyone is running a server on 'sid' - the docker image is still there for those few

but on that note the 'buster' distro is just as volatile trailing only a few weeks behind 'sid' so they should stay or go together - but the main thing is that this is not going to "break" until v9.7 comes out - which will not exactly be broken - it is just adding yet another version to the stack as you see has been done several times already - and regardless of debian, this would still be the case for the next bi-annual release of ubuntu that includes v9.7

practically speaking, ubuntu is actually the more troublesome target than debian because it is guaranteed to requires a routine update to these install files every 6 months - so to be consistent with this decision, note that dropping support for 'buster' and 'sid' and supporting only the LTS releases of debian is the equivalent to only supporting ubuntu LTS every 2 years and not supporting any of the interim versions as has been done all along

to be clear, the point i raised was that ubuntu support is actually more work to maintain than debian because it is guaranteed to requires a routine update to these install files every 6 months - even if no dependencies change, a new ubuntu entry would need to be added every 6 months - that would not be the case for debian - unless dependencies change, a new debian entry would not need to be added until the next debian LTS version in 2-3 years - if every ubuntu version is to be supported, then keeping 'buster' and 'sid' will be exactly zero additional work because whatever dependency versions ubuntu requires, they take from what is current in debian testing (currently buster)

But Ubuntu will at least not break in the future. Unless someone of the developers uses buster or sid, we will not recognize when the dependencies break on these systems.

And AFAIK we can not test the dependencies with travis (unless we set up docker files for that)?

wel as i said it will not "break" - it will just require a new version of the PG libs - and that WILL happen - and it will happen in buster and ubuntu at the same time (within a few months)

you could use debootstrap (or several other tools) to test the debian builds on travis - but yea it's probably more trouble than it's worth - to be consistent then i would suggest to drop support for the non-LTS versions of ubuntu because it is no easier to support those on travis right?

also as i mention on my original PR - the entire hassle of version numbers could be avoided by requiring the metapackages like:

postgresql-server-dev-all instead of postgresql-server-dev-9.5 or postgresql-server-dev-9.6 postgresql php php-pgsql php-cli php-curl php-xml instead of postgresql-9.5 libapache2-mod-php5 php5 php5-pgsql php5-cli php5-curl or postgresql-9.6 libapache2-mod-php7.0 php7.0 php7.0-pgsql php7.0-cli php7.0-curl php7.0-xml;;

just some ideas to lessen the maintenance load - fwiw - this is a nice feature but very few upstreams manage a script like this - they usually just post the dependencies in the README and let it to the user to prepare the environment and a ./configure script to verify it

Using metapackages leads to other problems. We explicitly use specific php and psql versions since we do not want to support all of them.

In my opinion, if one tries to install fossology on a not supported system, one should fail early in the install-deps-step instead of silently later, when some features in the application break.

+1 for the idea with the ./configure step for verifying dependencies.

maxhbr · 2017-07-17T11:57:40Z

src/www/ui/index.php

 plugin_unload();

 $container->get("db.manager")->flushStats();
-return 0;


unnecessary change.

maxhbr · 2017-07-17T11:59:05Z

src/lib/php/Test/TestLiteDb.php


-    $container->get('db.manager')->setDriver(new SqliteE($sqlite3Connection));
+    $liteDb = new SqliteE($sqlite3Connection);
+    $container->get('db.manager')->setDriver($liteDb);


why is this reformatting necessary?

because Only variables should be passed by reference starting with PHP 7.0

maxhbr · 2017-07-17T12:01:24Z

src/lib/php/Test/TestPgDb.php

-    $container->get('db.manager')->setDriver(new Postgres($this->connection));
+    $this->dbManager = $container->get('db.manager');
+    $postgres = new Postgres($this->connection);
+    $this->dbManager->setDriver($postgres);


why is this reformatting necessary? $this->dbManager gets overwritten in the next line (with the same object)!

maxhbr · 2017-07-17T12:02:27Z

src/composer.json

        "twig/twig": "1.*",
-        "twig/extensions": "1.*"
+        "twig/extensions": "1.*",
+        "phpunit/phpunit": "~5"


Why is it necessary to make phpunit a non-dev-dependency?

maxhbr

Code looks good

maxhbr

Please remove the support for buster and sid (as discussed in #857 (comment))

bill-auger · 2017-08-09T00:13:47Z

@MaximilianHuber -

to be clear, the point i raised was that ubuntu support is actually more work to maintain than debian because it is guaranteed to requires a routine update to these install files every 6 months - even if no dependencies change, a new ubuntu entry would need to be added every 6 months - that would not be the case for debian - unless dependencies change, a new debian entry would not need to be added until the next debian LTS version in 2-3 years - if every ubuntu version is to be supported, then keeping 'buster' and 'sid' will be exactly zero additional work because whatever dependency versions ubuntu requires, they take from what is current in debian testing (currently buster)

due to clearification in #857 (comment)

max-wittig · 2017-08-11T08:26:22Z

(from the discussion): add agent tests for PHP 7.0 and 7.1

keestux · 2017-09-01T14:21:51Z

utils/fo-installdeps

-                 apt-get $YesOpt install postgresql-9.5;;
+                 apt-get $YesOpt install postgresql-9.4 libapache2-mod-php5 php5 php5-pgsql php5-cli php5-curl;;
+              xenial|yakkety)
+                 apt-get $YesOpt install postgresql-9.5 libapache2-mod-php5 php5 php5-pgsql php5-cli php5-curl;;


Drop the '5' from php packages?

keestux - to be clear, when you say drop support for php5, what you are really suggesting is to drop support for: squeeze, wheezy, lucid, natty, isadora, precise, oneiric, quantal, raring, saucy, trusty, jessie, xenial, yakkety

if you are only suggesting to drop the number '5' and require the meta-packages php, php-pgsql, php-cli, php-curl, etc. instead of php,5 php5-pgsql, php5-cli, php5-curl - that has already been suggested in this PR

Nevermind. I just got confused by Github which showed commit a4af5cc, but which is not present in the fresh clone that I made.

* debian stretch,buster,sid * ubuntu yakkety,zesty,artful

mcjaeger · 2017-09-26T21:06:39Z

tested with debian 9 (net install) -> OK

tested with ubuntu 16.04.03 ->

composer fails, requires to be installed

sudo apt-get install php-mbstring
sudo apt-get install php-curl

to get the make install running.

Unfortunately, the fo-postinstall script fails with

PHP Fatal error:  Uncaught Error: Call to undefined function pg_connect() in /usr/local/share/fossology/lib/php/common-db.php:69
Stack trace:
#0 /usr/local/share/fossology/lib/php/common-sysconfig.php(101): DBconnect('/usr/local/etc/...')
#1 /usr/local/lib/fossology/fossinit.php(115): ConfigInit('/usr/local/etc/...', Array)
#2 {main}
  thrown in /usr/local/share/fossology/lib/php/common-db.php on line 69
PHP Fatal error:  Uncaught Error: Call to undefined function pg_connect() in /usr/local/share/fossology/lib/php/common-db.php:69
Stack trace:
#0 /usr/local/share/fossology/lib/php/common-sysconfig.php(101): DBconnect('/usr/local/etc/...')
#1 /usr/local/lib/fossology/fo_dbcheck.php(63): ConfigInit('/usr/local/etc/...', Array)
#2 {main}
  thrown in /usr/local/share/fossology/lib/php/common-db.php on line 69
FATAL: unable to connect to database, please check /usr/local/etc/fossology/Db.conf

(package postgresql-server-dev-9.5 is installed and db is running)

bill-auger · 2017-09-27T22:27:38Z

@mcjaeger -

did you solve that error? i noticed it is exactly the same error as i got compiling on parabola

#864

max-wittig force-pushed the fix/debian branch from 57beb45 to a331b4f Compare June 21, 2017 13:40

max-wittig added the do not merge - нет! label Jun 23, 2017

max-wittig force-pushed the fix/debian branch from a331b4f to 43fa565 Compare June 23, 2017 10:37

max-wittig mentioned this pull request Jun 26, 2017

update packages deps for latest debian and ubuntus #861

Closed

mcjaeger self-assigned this Jun 27, 2017

max-wittig force-pushed the fix/debian branch 9 times, most recently from 4123bb9 to bcf897f Compare July 11, 2017 14:14

max-wittig removed the do not merge - нет! label Jul 11, 2017

maxhbr reviewed Jul 12, 2017

View reviewed changes

maxhbr requested changes Jul 12, 2017

View reviewed changes

max-wittig added the do not merge - нет! label Jul 12, 2017

max-wittig force-pushed the fix/debian branch 2 times, most recently from 90b226c to 8e13de7 Compare July 12, 2017 11:27

max-wittig removed the do not merge - нет! label Jul 12, 2017

max-wittig force-pushed the fix/debian branch from 8e13de7 to 2632579 Compare July 13, 2017 12:10

maxhbr self-requested a review July 14, 2017 08:37

maxhbr requested changes Jul 18, 2017

View reviewed changes

max-wittig force-pushed the fix/debian branch 2 times, most recently from 8314497 to d40b941 Compare July 18, 2017 12:50

max-wittig requested a review from maxhbr July 18, 2017 13:25

maxhbr approved these changes Jul 18, 2017

View reviewed changes

mcjaeger removed their assignment Jul 19, 2017

mcjaeger assigned shaheemazmalmmd Jul 19, 2017

maxhbr mentioned this pull request Jul 23, 2017

can not view copyright page (debian9 / PHP7) #860

Closed

max-wittig force-pushed the fix/debian branch from d40b941 to 1cc3859 Compare July 24, 2017 07:21

maxhbr previously requested changes Aug 8, 2017

View reviewed changes

maxhbr mentioned this pull request Aug 18, 2017

fix(php): resolve pass-by-reference errors #893

Closed

maxhbr mentioned this pull request Aug 30, 2017

Source Code install of 3.1 for Ubuntu 16.04 LTS fails #895

Closed

max-wittig force-pushed the fix/debian branch 2 times, most recently from 60b1157 to a4af5cc Compare September 1, 2017 12:02

keestux reviewed Sep 1, 2017

View reviewed changes

mcjaeger self-assigned this Sep 12, 2017

max-wittig force-pushed the fix/debian branch from a4af5cc to 68f5eb5 Compare September 13, 2017 09:17

max-wittig and others added 2 commits September 13, 2017 11:21

fix(debian9): add compatibility with debian9

55ce2bb

fix(install): update packages deps for latest debian and ubuntu

c1f4cdb

* debian stretch,buster,sid * ubuntu yakkety,zesty,artful

max-wittig force-pushed the fix/debian branch from 68f5eb5 to c1f4cdb Compare September 13, 2017 09:21

mcjaeger merged commit 1ce56b8 into fossology:master Sep 27, 2017

GMishx deleted the fix/debian branch June 3, 2021 08:09

fix(debian9): add compatibility with debian9 #857

fix(debian9): add compatibility with debian9 #857

Uh oh!

Conversation

max-wittig commented Jun 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

max-wittig commented Jun 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maxhbr left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bill-auger Aug 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maxhbr left a comment

Choose a reason for hiding this comment

Uh oh!

maxhbr left a comment

Choose a reason for hiding this comment

Uh oh!

bill-auger commented Aug 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

max-wittig commented Aug 11, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mcjaeger commented Sep 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bill-auger commented Sep 27, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

max-wittig commented Jun 21, 2017 •

edited

Loading

max-wittig commented Jun 23, 2017 •

edited

Loading

bill-auger Aug 9, 2017 •

edited

Loading

bill-auger commented Aug 9, 2017 •

edited

Loading

mcjaeger commented Sep 26, 2017 •

edited

Loading