Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
f062376
set experimentalAutoDetectLongPolling default value to true
dconeybe Apr 20, 2023
65d5e9c
changeset
dconeybe Apr 20, 2023
959c0e7
Firestore: database.test.ts: add unit tests for long polling settings…
dconeybe Apr 20, 2023
7f52fe4
Merge branch 'LongPollingSettingsTests' into AutoDetectLongPollingEna…
dconeybe Apr 20, 2023
ac752d1
Update documentation of experimentalAutoDetectLongPolling to document…
dconeybe Apr 20, 2023
8218910
reword changeset
dconeybe Apr 20, 2023
09d6f31
yarn docgen devsite
dconeybe Apr 20, 2023
40f2018
Merge remote-tracking branch 'origin/master' into AutoDetectLongPolli…
dconeybe Apr 20, 2023
eb854dc
Firestore: settings.ts: very minor refactor of long-polling logic.
dconeybe Apr 20, 2023
75b2c9b
Merge branch 'LongPollingLogicTweak' into AutoDetectLongPollingEnable…
dconeybe Apr 20, 2023
ef8665f
invert negative 'if' statement and ensure that experimentalAutoDetect…
dconeybe Apr 20, 2023
e0e0741
Merge branch 'LongPollingLogicTweak' into AutoDetectLongPollingEnable…
dconeybe Apr 20, 2023
8e84d43
add DEFAULT_AUTO_DETECT_LONG_POLLING and coerce to boolean
dconeybe Apr 20, 2023
3e2be99
Firestore: database.test.ts: add tests for coercing experimentalForce…
dconeybe Apr 20, 2023
d8fccbe
yarn prettier
dconeybe Apr 20, 2023
7427858
tweak unit test descriptions
dconeybe Apr 20, 2023
81a61b4
add `// eslint-disable-next-line @typescript-eslint/no-explicit-any` …
dconeybe Apr 20, 2023
10aba36
Merge branch 'LongPollingCoerceToBooleanTests' into LongPollingLogicT…
dconeybe Apr 20, 2023
17519c3
invert a negative 'if' statement
dconeybe Apr 20, 2023
7522b43
Merge remote-tracking branch 'remotes/origin/dconeybe/LongPollingLogi…
dconeybe Apr 20, 2023
c27a49a
Merge remote-tracking branch 'origin/master' into LongPollingLogicTweak
dconeybe Apr 20, 2023
a9696c5
Merge branch 'LongPollingLogicTweak' into AutoDetectLongPollingEnable…
dconeybe Apr 20, 2023
b64dc66
Merge remote-tracking branch 'origin/master' into AutoDetectLongPolli…
dconeybe Apr 21, 2023
f166d1d
tweak api docs for experimentalAutoDetectLongPolling, as suggested in…
dconeybe Apr 21, 2023
e58f70b
Merge remote-tracking branch 'origin/master' into AutoDetectLongPolli…
dconeybe May 5, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge remote-tracking branch 'origin/master' into AutoDetectLongPolli…
…ngEnabledByDefault
  • Loading branch information
dconeybe committed May 5, 2023
commit e58f70be9f2a9d67f1564ff96ec5ef597d2933c4
12 changes: 12 additions & 0 deletions packages/firestore/src/lite-api/settings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,18 @@ import { validateIsNotUsedTogether } from '../util/input_validation';
export const DEFAULT_HOST = 'firestore.googleapis.com';
export const DEFAULT_SSL = true;

// The minimum long-polling timeout is hardcoded on the server. The value here
// should be kept in sync with the value used by the server, as the server will
// silently ignore a value below the minimum and fall back to the default.
// Googlers see b/266868871 for relevant discussion.
const MIN_LONG_POLLING_TIMEOUT_SECONDS = 5;

// No maximum long-polling timeout is configured in the server, and defaults to
// 30 seconds, which is what Watch appears to use.
// Googlers see b/266868871 for relevant discussion.
const MAX_LONG_POLLING_TIMEOUT_SECONDS = 30;

// Whether long-polling auto-detected is enabled by default.
const DEFAULT_AUTO_DETECT_LONG_POLLING = true;

/**
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.