Skip to content

Firestore: Enable auto-detection of long-polling networking mode #7236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
May 8, 2023
Merged

Firestore: Enable auto-detection of long-polling networking mode #7236

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
f062376
set experimentalAutoDetectLongPolling default value to true
dconeybe Apr 20, 2023
65d5e9c
changeset
dconeybe Apr 20, 2023
959c0e7
Firestore: database.test.ts: add unit tests for long polling settings…
dconeybe Apr 20, 2023
7f52fe4
Merge branch 'LongPollingSettingsTests' into AutoDetectLongPollingEna…
dconeybe Apr 20, 2023
ac752d1
Update documentation of experimentalAutoDetectLongPolling to document…
dconeybe Apr 20, 2023
8218910
reword changeset
dconeybe Apr 20, 2023
09d6f31
yarn docgen devsite
dconeybe Apr 20, 2023
40f2018
Merge remote-tracking branch 'origin/master' into AutoDetectLongPolli…
dconeybe Apr 20, 2023
eb854dc
Firestore: settings.ts: very minor refactor of long-polling logic.
dconeybe Apr 20, 2023
75b2c9b
Merge branch 'LongPollingLogicTweak' into AutoDetectLongPollingEnable…
dconeybe Apr 20, 2023
ef8665f
invert negative 'if' statement and ensure that experimentalAutoDetect…
dconeybe Apr 20, 2023
e0e0741
Merge branch 'LongPollingLogicTweak' into AutoDetectLongPollingEnable…
dconeybe Apr 20, 2023
8e84d43
add DEFAULT_AUTO_DETECT_LONG_POLLING and coerce to boolean
dconeybe Apr 20, 2023
3e2be99
Firestore: database.test.ts: add tests for coercing experimentalForce…
dconeybe Apr 20, 2023
d8fccbe
yarn prettier
dconeybe Apr 20, 2023
7427858
tweak unit test descriptions
dconeybe Apr 20, 2023
81a61b4
add `// eslint-disable-next-line @typescript-eslint/no-explicit-any` …
dconeybe Apr 20, 2023
10aba36
Merge branch 'LongPollingCoerceToBooleanTests' into LongPollingLogicT…
dconeybe Apr 20, 2023
17519c3
invert a negative 'if' statement
dconeybe Apr 20, 2023
7522b43
Merge remote-tracking branch 'remotes/origin/dconeybe/LongPollingLogi…
dconeybe Apr 20, 2023
c27a49a
Merge remote-tracking branch 'origin/master' into LongPollingLogicTweak
dconeybe Apr 20, 2023
a9696c5
Merge branch 'LongPollingLogicTweak' into AutoDetectLongPollingEnable…
dconeybe Apr 20, 2023
b64dc66
Merge remote-tracking branch 'origin/master' into AutoDetectLongPolli…
dconeybe Apr 21, 2023
f166d1d
tweak api docs for experimentalAutoDetectLongPolling, as suggested in…
dconeybe Apr 21, 2023
e58f70b
Merge remote-tracking branch 'origin/master' into AutoDetectLongPolli…
dconeybe May 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tweak unit test descriptions
  • Loading branch information
@dconeybe
dconeybe committed Apr 20, 2023
commit 74278583e313401753b6ed6ffc75243cc99ea432
8 changes: 4 additions & 4 deletions packages/firestore/test/unit/api/database.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ describe('Settings', () => {
expect(db._getSettings().experimentalForceLongPolling).to.be.false;
});

it('long polling autoDetect=[something truthy] is corced to true', () => {
it('long polling autoDetect=[something truthy] should be coerced to true', () => {
// Use a new instance of Firestore in order to configure settings.
const db = newTestFirestore();
db._setSettings({
Expand All @@ -368,7 +368,7 @@ describe('Settings', () => {
expect(db._getSettings().experimentalAutoDetectLongPolling).to.be.true;
});

it('long polling autoDetect=[something falsy] is corced to false', () => {
it('long polling autoDetect=[something falsy] should be coerced to false', () => {
// Use a new instance of Firestore in order to configure settings.
const db = newTestFirestore();
db._setSettings({
Expand All @@ -377,7 +377,7 @@ describe('Settings', () => {
expect(db._getSettings().experimentalAutoDetectLongPolling).to.be.false;
});

it('long polling force=[something truthy] is corced to true', () => {
it('long polling force=[something truthy] should be coerced to true', () => {
// Use a new instance of Firestore in order to configure settings.
const db = newTestFirestore();
db._setSettings({
Expand All @@ -386,7 +386,7 @@ describe('Settings', () => {
expect(db._getSettings().experimentalForceLongPolling).to.be.true;
});

it('long polling force=[something falsy] is corced to false', () => {
it('long polling force=[something falsy] should be coerced to false', () => {
// Use a new instance of Firestore in order to configure settings.
const db = newTestFirestore();
db._setSettings({
Expand Down