[Auth] Forward secure coding calls for TOTPMultiFactorInfo #13592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncooke3
commented
Sep 5, 2024
ncooke3
commented
Sep 5, 2024
There was a problem hiding this comment.
Despite being marked unavailable, this class's init?(coder:) is actually called when totp is registered:
paulb777
approved these changes
Sep 6, 2024
|
I'm not sure now is the time to address it, but |
ncooke3
commented
Sep 6, 2024
Comment on lines
-25
to
-26
| /// This is the totp info for the second factor. | ||
| let totpInfo: NSObject? |
There was a problem hiding this comment.
Typing this with a more specific type (dictionary) added a more code to cast it during encoding and decoding. I stepped back and see that this property is never read from (it's only read from from the AuthProtoMFAEnrollment.swift class). I think it's better to just remove it as it's addition is more confusing.
ncooke3
commented
Sep 6, 2024
|
I was able to successfully enroll via TOTP in the sample app using these changes. |
ncooke3
added a commit
that referenced
this pull request
Sep 7, 2024
ncooke3
added a commit
that referenced
this pull request
Sep 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13591
totpInfoproperty because it's not used. The property onAuthProtoMFAEnrollmentis enough (e.g.git grep "\.totpInfo" -- FirebaseAuth/Sources/Swift.firebase-ios-sdk/FirebaseAuth/Sources/Swift/Backend/RPC/Proto/AuthProtoMFAEnrollment.swift
Line 19 in ed4269b