Skip to content

[Auth] Forward secure coding calls for TOTPMultiFactorInfo #13592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 7, 2024
Merged

[Auth] Forward secure coding calls for TOTPMultiFactorInfo #13592

merged 7 commits into from
Sep 7, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Sep 5, 2024 •
edited
Loading

Fix #13591

nickcooke@nickcooke-mac firebase-3 % git grep "\.totpInfo" -- FirebaseAuth/Sources/Swift
FirebaseAuth/Sources/Swift/Backend/AuthBackend.swift:          } else if let _ = enrollment.totpInfo {
FirebaseAuth/Sources/Swift/MultiFactor/MultiFactor.swift:        } else if enrollment.totpInfo != nil {

ncooke3
ncooke3 commented Sep 5, 2024
View reviewed changes
FirebaseAuth/Sources/Swift/MultiFactor/TOTP/TOTPMultiFactorInfo.swift
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite being marked unavailable, this class's init?(coder:) is actually called when totp is registered:

firebase-ios-sdk/FirebaseAuth/Sources/Swift/MultiFactor/MultiFactor.swift

Line 289 in 60b6dd5

coder.encode(enrolledFactors, forKey: kEnrolledFactorsCodingKey)

paulb777
paulb777 approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Will need to be cherry-picked to 11.2 branch as well.

@ncooke3
Copy link
Member Author

ncooke3 commented