Add static-framework testing to CI #6599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanwilson
reviewed
Sep 30, 2020
Gemfile
Outdated
| gem 'cocoapods', "1.9.3" | ||
| gem 'cocoapods-generate', '2.0.0' | ||
| gem 'cocoapods', '1.10.0.rc.1' | ||
| gem 'cocoapods-generate', git: "https://github.com/square/cocoapods-generate.git", branch: "master" |
There was a problem hiding this comment.
Can we use a commit instead of pointing at master here?
There was a problem hiding this comment.
Good point. That's safer. Done.
ryanwilson
approved these changes
Sep 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that static framework's are off by default, make sure we still test when it is turned back on.
Remove
--use-modular-headerstesting since it is mostly redundant with--use-static-frameworksand no longer a recommended option.All tests passed before turning cron back on
Note that the
--use-static-frameworkpod lib lint option is introduced in CocoaPods 1.10#no-changelog