Skip to content

Add static-framework testing to CI #6599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 30, 2020
Merged

Add static-framework testing to CI #6599

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6f839ec
Add static-framework testing to CI
paulb777 Sep 29, 2020
4262d97
fixes
paulb777 Sep 29, 2020
416e2f8
Restore cron and remove use-modular-headers
paulb777 Sep 29, 2020
53aa9d7
one more
paulb777 Sep 29, 2020
540156f
Use hash instead of branch
paulb777 Sep 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixes
  • Loading branch information
@paulb777
paulb777 committed Sep 29, 2020
commit 4262d973d2b292200055197cafad4bc1b5b0ce0c
3 changes: 1 addition & 2 deletions .github/workflows/auth.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,7 @@ jobs:
- name: Setup Bundler
run: scripts/setup_bundler.sh
- name: PodLibLint Auth Cron
run: scripts/third_party/travis/retry.sh scripts/pod_lib_lint.rb FirebaseAuth.podspec \
--platforms=${{ matrix.target }} ${{ matrix.flags }}
run: scripts/third_party/travis/retry.sh scripts/pod_lib_lint.rb FirebaseAuth.podspec --platforms=${{ matrix.target }} ${{ matrix.flags }}

archive-cron:
# Don't run on private repo.
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/remoteconfig.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ jobs:
matrix:
target: [ios, tvos, macos]
flags: [
'--use-static-frameworks',
'--skip-tests --use-static-frameworks',
'--skip-tests --use-modular-headers',
'--skip-tests --use-libraries'
]
Expand Down
4 changes: 3 additions & 1 deletion FirebaseDynamicLinks/Tests/Unit/FIRDynamicLinkNetworkingTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,10 @@

#import <OCMock/OCMock.h>

#import <GoogleUtilities/GULSwizzler+Unswizzle.h>
// This needs to precede the GULSwizzler+Unswizzle.h import for the --use-libraries build.
#import <GoogleUtilities/GULSwizzler.h>

#import <GoogleUtilities/GULSwizzler+Unswizzle.h>
#import "FirebaseDynamicLinks/Sources/FIRDynamicLinkNetworking+Private.h"

static NSString *const kAPIKey = @"myfakeapikey";
Expand Down
4 changes: 3 additions & 1 deletion FirebaseDynamicLinks/Tests/Unit/FIRDynamicLinksTest.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,10 @@

#import <XCTest/XCTest.h>

#import <GoogleUtilities/GULSwizzler+Unswizzle.h>
// This needs to precede the GULSwizzler+Unswizzle.h import for the --use-libraries build.
#import <GoogleUtilities/GULSwizzler.h>

#import <GoogleUtilities/GULSwizzler+Unswizzle.h>
#import <OCMock/OCMock.h>
#import "FirebaseCore/Sources/Private/FirebaseCoreInternal.h"
#import "FirebaseDynamicLinks/Sources/FIRDLDefaultRetrievalProcessV2.h"
Expand Down