Skip to content

Move PackageValidation to sdk with opt-in flag #19209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 29, 2021
Merged

Move PackageValidation to sdk with opt-in flag #19209

merged 8 commits into from
Jul 29, 2021

Conversation

Anipik
Copy link
Contributor

@Anipik Anipik commented Jul 23, 2021

  • Add EnablePackageValidation opt-in flag
  • Use roslyn version that comes with sdk.
  • remove any dependencies from the package.
  • add infra to override the package validation tasks and targets.

tests conducted

  • works with core-msbuild & inbox compiler
  • works with desktop-msbuild
  • works with core-msbuild & out of band compiler
  • works with core-msbuild, inbox compiler and package reference to validation package.

@Anipik Anipik requested review from ViktorHofer, ericstj and safern July 23, 2021 18:55
@ghost
Copy link

ghost commented Jul 23, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

ericstj
ericstj reviewed Jul 23, 2021
View reviewed changes
src/Compatibility/Microsoft.DotNet.PackageValidation/Microsoft.DotNet.PackageValidation.csproj Outdated
<PackageReference Include="NuGet.Frameworks" Version="$(NuGetBuildTasksPackageVersion)" ExcludeAssets="Runtime" />
<PackageReference Include="NuGet.Packaging" Version="$(NuGetBuildTasksPackageVersion)" ExcludeAssets="Runtime" />
<PackageReference Include="NuGet.Protocol" Version="$(NuGetBuildTasksPackageVersion)" ExcludeAssets="Runtime" />
<PackageReference Include="System.IO.Compression" Version="4.3.0" ExcludeAssets="Runtime" />
Copy link
Member

@ericstj ericstj Jul 23, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect ExcludeAssets to be transitive and all other references are excluded. Why did you need to add this?

@ericstj ericstj requested review from RikkiGibson and chsienki July 26, 2021 17:46
safern
safern reviewed Jul 26, 2021
View reviewed changes
ericstj
ericstj reviewed Jul 27, 2021
View reviewed changes
@Anipik Anipik requested a review from rainersigwald July 27, 2021 17:05
@RikkiGibson RikkiGibson self-assigned this Jul 28, 2021
RikkiGibson
RikkiGibson reviewed Jul 28, 2021
View reviewed changes
@chsienki chsienki mentioned this pull request Jul 28, 2021
Open
safern
safern approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Anipik @safern
Removing extra space
a30b043 
Co-authored-by: Santiago Fernandez Madero <[email protected]>
@Anipik Anipik merged commit 18a3421 into dotnet:main Jul 29, 2021
@Anipik Anipik mentioned this pull request Jul 30, 2021
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RikkiGibson RikkiGibson RikkiGibson left review comments

@ViktorHofer ViktorHofer ViktorHofer left review comments

@ericstj ericstj ericstj left review comments

@safern safern safern approved these changes

@chsienki chsienki Awaiting requested review from chsienki

@rainersigwald rainersigwald Awaiting requested review from rainersigwald

Assignees

@RikkiGibson RikkiGibson

Labels

Area-ApiCompat

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Anipik @RikkiGibson @ViktorHofer @ericstj @chsienki @safern @marcpopMSFT