Skip to content

Move PackageValidation to sdk with opt-in flag #19209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 29, 2021
Merged

Move PackageValidation to sdk with opt-in flag #19209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a669893
inbox the package Validation
Anipik Jul 23, 2021
68bc489
add min roslun version check, remove hashcode version and some other …
Anipik Jul 26, 2021
fe75633
fix some test failures and roslyn min version
Anipik Jul 27, 2021
6b373d0
add msbuld targets to the package.
Anipik Jul 27, 2021
d1f5ec3
add support of multitarget projects
Anipik Jul 28, 2021
a30b043
Removing extra space
Anipik Jul 28, 2021
0606543
use tasks existing property
Anipik Jul 28, 2021
974e68e
Revert "use tasks existing property"
safern Jul 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/Assets/TestProjects/PackageValidationTestProject/PackageValidationTestProject.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>netstandard2.0;net6.0</TargetFrameworks>
<DefineConstants Condition="'$(ForceValidationProblem)' == 'true'">$(DefineConstants);ForceValidationProblem</DefineConstants>
<DefineConstants Condition="'$(AddBreakingChange)' == 'true'">$(DefineConstants);AddBreakingChange</DefineConstants>
<CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>
<EnablePackageValidation>true</EnablePackageValidation>
</PropertyGroup>

<ItemGroup>
Expand All @@ -15,8 +16,8 @@
<PackageReference Include="Microsoft.CodeAnalysis" Version="4.0.0-1.21277.15" />
</ItemGroup>

<Import Project="$(MSBuildProjectDirectory)\..\..\..\..\src\Compatibility\Microsoft.DotNet.PackageValidation\build\Microsoft.DotNet.PackageValidation.targets" />
<Import Project="$(MSBuildProjectDirectory)\..\..\..\..\src\Tasks\Microsoft.NET.Build.Tasks\targets\Microsoft.NET.Compatibility.targets" />

<PropertyGroup>
<DotNetPackageValidationAssembly Condition="'$(MSBuildRuntimeType)' != 'Core'">$(MSBuildThisFileDirectory)\bin\$(Configuration)\netstandard2.0\Microsoft.DotNet.PackageValidation.dll</DotNetPackageValidationAssembly>
<DotNetPackageValidationAssembly Condition="'$(MSBuildRuntimeType)' == 'Core'">$(MSBuildThisFileDirectory)\bin\$(Configuration)\net6.0\Microsoft.DotNet.PackageValidation.dll</DotNetPackageValidationAssembly>
Expand Down
10 changes: 9 additions & 1 deletion src/Compatibility/Microsoft.DotNet.ApiCompatibility/Abstractions/MetadataInformation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Licensed under the MIT license. See LICENSE file in the project root for full license information.

using System;
using System.Collections.Generic;

namespace Microsoft.DotNet.ApiCompatibility.Abstractions
{
Expand Down Expand Up @@ -29,6 +30,13 @@ public bool Equals(MetadataInformation other) =>
string.Equals(TargetFramework, other.TargetFramework, StringComparison.OrdinalIgnoreCase) &&
string.Equals(AssemblyId, other.AssemblyId, StringComparison.Ordinal);

public override int GetHashCode() => HashCode.Combine(AssemblyName, TargetFramework, AssemblyId);
public override int GetHashCode()
{
int hashCode = 1447485498;
hashCode = hashCode * -1521134295 + EqualityComparer<string>.Default.GetHashCode(AssemblyName);
hashCode = hashCode * -1521134295 + EqualityComparer<string>.Default.GetHashCode(TargetFramework);
hashCode = hashCode * -1521134295 + EqualityComparer<string>.Default.GetHashCode(AssemblyId);
return hashCode;
}
}
}
6 changes: 5 additions & 1 deletion src/Compatibility/Microsoft.DotNet.ApiCompatibility/DiagnosticBag.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,11 @@ public class DiagnosticBag<T> where T : IDiagnostic

public DiagnosticBag(IEnumerable<string> noWarn, (string diagnosticId, string referenceId)[] ignoredDifferences)
{
_noWarn = new HashSet<string>(noWarn);
if (noWarn != null)
_noWarn = new HashSet<string>(noWarn);
else
_noWarn = new HashSet<string>();

_ignore = new Dictionary<string, HashSet<string>>();

if (ignoredDifferences != null)
Expand Down
11 changes: 10 additions & 1 deletion src/Compatibility/Microsoft.DotNet.ApiCompatibility/ErrorSuppression/Suppression.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

#nullable enable
using System;
using System.Collections.Generic;
using System.Xml.Serialization;

namespace Microsoft.DotNet.Compatibility.ErrorSuppression
Expand Down Expand Up @@ -54,6 +55,14 @@ static bool AreEqual(string? first, string? second)
=> string.IsNullOrEmpty(first?.Trim()) && string.IsNullOrEmpty(second?.Trim()) || StringComparer.InvariantCultureIgnoreCase.Equals(first?.Trim(), second?.Trim());
}

public override int GetHashCode() => HashCode.Combine(DiagnosticId?.ToLowerInvariant(), Target?.ToLowerInvariant(), Left?.ToLowerInvariant(), Right?.ToLowerInvariant(), IsBaselineSuppression);
public override int GetHashCode()
{
int hashCode = 1447485498;
hashCode = hashCode * -1521134295 + EqualityComparer<string>.Default.GetHashCode(DiagnosticId?.ToLowerInvariant() ?? string.Empty);
hashCode = hashCode * -1521134295 + EqualityComparer<string>.Default.GetHashCode(Target?.ToLowerInvariant() ?? string.Empty);
hashCode = hashCode * -1521134295 + EqualityComparer<string>.Default.GetHashCode(Left?.ToLowerInvariant() ?? string.Empty);
hashCode = hashCode * -1521134295 + EqualityComparer<string>.Default.GetHashCode(Right?.ToLowerInvariant() ?? string.Empty);
return hashCode;
}
}
}
1 change: 0 additions & 1 deletion src/Compatibility/Microsoft.DotNet.ApiCompatibility/Microsoft.DotNet.ApiCompatibility.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Bcl.HashCode" Version="1.1.1" />
<PackageReference Include="Microsoft.CodeAnalysis" Version="$(MicrosoftCodeAnalysisCSharpPackageVersion)" />
</ItemGroup>

Expand Down
18 changes: 12 additions & 6 deletions ...ompatibility/Microsoft.DotNet.PackageValidation/Microsoft.DotNet.PackageValidation.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>netcoreapp3.1;net472</TargetFrameworks>
<TargetFrameworks>net6.0;net472</TargetFrameworks>
<IsPackable>true</IsPackable>
<IsShippingPackage>true</IsShippingPackage>
<StrongNameKeyId>Open</StrongNameKeyId>
Expand All @@ -15,10 +15,11 @@
<Compile Include="..\..\Tasks\Common\**\*.cs" LinkBase="Common" />
<PackageReference Include="Microsoft.Build.Framework" Version="$(MicrosoftBuildFrameworkVersion)" ExcludeAssets="Runtime" />
<PackageReference Include="Microsoft.Build.Utilities.Core" Version="$(MicrosoftBuildUtilitiesCoreVersion)" ExcludeAssets="Runtime" />
<PackageReference Include="NuGet.Frameworks" Version="$(NuGetBuildTasksPackageVersion)" />
<PackageReference Include="NuGet.Packaging" Version="$(NuGetBuildTasksPackageVersion)" />
<PackageReference Include="NuGet.Protocol" Version="$(NuGetBuildTasksPackageVersion)" />
<ProjectReference Include="..\Microsoft.DotNet.ApiCompatibility\Microsoft.DotNet.ApiCompatibility.csproj" />
<PackageReference Include="NuGet.Frameworks" Version="$(NuGetBuildTasksPackageVersion)" ExcludeAssets="Runtime" />
<PackageReference Include="NuGet.Packaging" Version="$(NuGetBuildTasksPackageVersion)" ExcludeAssets="Runtime" />
<PackageReference Include="NuGet.Protocol" Version="$(NuGetBuildTasksPackageVersion)" ExcludeAssets="Runtime" />
<PackageReference Include="System.IO.Compression" Version="4.3.0" />
<ProjectReference Include="..\Microsoft.DotNet.ApiCompatibility\Microsoft.DotNet.ApiCompatibility.csproj" ExcludeAssets="Runtime" />
</ItemGroup>

<ItemGroup>
Expand All @@ -34,6 +35,10 @@
<None Include="**/*.props;**/*.targets" Pack="true">
<PackagePath>%(RecursiveDir)%(Filename)%(Extension)</PackagePath>
</None>
<None Include="..\..\Tasks\Microsoft.NET.Build.Tasks\targets\Microsoft.NET.Compatibility.Common.targets" Pack="true" >
<Link>build/Microsoft.NET.Compatibility.Common.targets</Link>
<PackagePath>build/%(Filename)%(Extension)</PackagePath>
</None>
</ItemGroup>

<ItemGroup>
Expand Down Expand Up @@ -81,7 +86,8 @@
<Target Name="_AddBuildOutputToPackageDesktop" Condition="'$(TargetFrameworkIdentifier)' != '.NETCoreApp'">
<ItemGroup>
<!-- Include .NET Framework build outputs in the package under tools directory. -->
<TfmSpecificPackageFile Include="$(OutputPath)**" PackagePath="tools/$(TargetFramework)/%(RecursiveDir)%(FileName)%(Extension)"/>
<TfmSpecificPackageFile Include="$(OutputPath)**"
PackagePath="tools/$(TargetFramework)/%(RecursiveDir)%(FileName)%(Extension)" />
</ItemGroup>
</Target>

Expand Down
3 changes: 3 additions & 0 deletions src/Compatibility/Microsoft.DotNet.PackageValidation/Resources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,4 +153,7 @@
<data name="Baseline" xml:space="preserve">
<value>[Baseline]</value>
</data>
<data name="UpdateSdkVersion" xml:space="preserve">
<value> The minimum version required of Roslyn is '{1}' and you are using '{0}' version of the Roslyn. You can update the sdk to get the latest version.</value>
</data>
</root>
35 changes: 35 additions & 0 deletions src/Compatibility/Microsoft.DotNet.PackageValidation/ValidatePackage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
// Copyright (c) .NET Foundation and contributors. All rights reserved.
// Licensed under the MIT license. See LICENSE file in the project root for full license information.

using System;
using System.IO;
using System.Reflection;
using Microsoft.Build.Framework;
using Microsoft.NET.Build.Tasks;
using NuGet.RuntimeModel;
Expand All @@ -12,6 +15,9 @@ public class ValidatePackage : TaskBase
[Required]
public string PackageTargetPath { get; set; }

[Required]
public string RoslynAssembliesPath { get; set; }

public string RuntimeGraph { get; set; }

public string NoWarn { get; set; }
Expand All @@ -30,6 +36,19 @@ public class ValidatePackage : TaskBase

public string CompatibilitySuppressionFilePath { get; set; }

public override bool Execute()
{
AppDomain.CurrentDomain.AssemblyResolve += ResolverForRoslyn;
try
{
return base.Execute();
}
finally
{
AppDomain.CurrentDomain.AssemblyResolve -= ResolverForRoslyn;
}
}

protected override void ExecuteCore()
{
RuntimeGraph runtimeGraph = null;
Expand All @@ -55,5 +74,21 @@ protected override void ExecuteCore()
logger.GenerateSuppressionsFile(CompatibilitySuppressionFilePath);
}
}

private Assembly ResolverForRoslyn(object sender, ResolveEventArgs args)
{
AssemblyName name = new(args.Name);
if (name.Name == "Microsoft.CodeAnalysis" || name.Name == "Microsoft.CodeAnalysis.CSharp")
{
Assembly asm = Assembly.LoadFrom(Path.Combine(RoslynAssembliesPath, $"{name.Name}.dll"));
Version version = asm.GetName().Version;
if (version < name.Version)
{
throw new Exception(string.Format(Resources.UpdateSdkVersion, version, name.Version));
}
return asm;
}
return null;
}
}
}
36 changes: 6 additions & 30 deletions ...ility/Microsoft.DotNet.PackageValidation/build/Microsoft.DotNet.PackageValidation.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,34 +1,10 @@
<!-- Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license. -->
<Project>
<UsingTask TaskName="Microsoft.DotNet.PackageValidation.ValidatePackage" AssemblyFile="$(DotNetPackageValidationAssembly)" />
<PropertyGroup>
<DotNetPackageValidationAssembly Condition="'$(MSBuildRuntimeType)' != 'Core'">$(MSBuildThisFileDirectory)..\tools\net472\Microsoft.DotNet.PackageValidation.dll</DotNetPackageValidationAssembly>
<DotNetPackageValidationAssembly Condition="'$(MSBuildRuntimeType)' == 'Core'">$(MSBuildThisFileDirectory)..\tools\net6.0\Microsoft.DotNet.PackageValidation.dll</DotNetPackageValidationAssembly>
<UseCompatibilityPackage>true</UseCompatibilityPackage>
</PropertyGroup>

<ItemGroup Condition="'$(DisablePackageBaselineValidation)' != 'true' and '$(PackageValidationBaselinePath)' == '' and '$(PackageValidationBaselineVersion)' != ''">
<PackageDownload Include="$([MSBuild]::ValueOrDefault('$(PackageValidationBaselineName)', '$(PackageId)'))" Version="[$(PackageValidationBaselineVersion)]" />
</ItemGroup>

<Target Name="RunPackageValidation"
AfterTargets="Pack"
Condition="'$(IsPackable)' == 'true'">

<PropertyGroup>
<PackageValidationBaselineName Condition="'$(PackageValidationBaselineName)' == ''">$(PackageId)</PackageValidationBaselineName>
<PackageValidationBaselinePath Condition="'$(PackageValidationBaselinePath)' == '' and '$(PackageValidationBaselineVersion)' != ''">$([MSBuild]::NormalizePath('$(NuGetPackageRoot)', '$(PackageValidationBaselineName.ToLower())', '$(PackageValidationBaselineVersion)', '$(PackageValidationBaselineName.ToLower()).$(PackageValidationBaselineVersion).nupkg'))</PackageValidationBaselinePath>
<GenerateCompatibilitySuppressionFile Condition="'$(GenerateCompatibilitySuppressionFile)' == ''">false</GenerateCompatibilitySuppressionFile>
<_compatibilitySuppressionFilePath>$([MSBuild]::NormalizePath('$(MSBuildProjectDirectory)', 'CompatibilitySuppressions.xml'))</_compatibilitySuppressionFilePath>
<CompatibilitySuppressionFilePath Condition="'$(CompatibilitySuppressionFilePath)' == '' and (Exists($(_compatibilitySuppressionFilePath)) or '$(GenerateCompatibilitySuppressionFile)' == 'true')">$(_compatibilitySuppressionFilePath)</CompatibilitySuppressionFilePath>
</PropertyGroup>

<!-- PackageTargetPath isn't exposed by NuGet: https://github.com/NuGet/Home/issues/6671. -->
<Microsoft.DotNet.PackageValidation.ValidatePackage
PackageTargetPath="$([MSBuild]::ValueOrDefault('$(PackageTargetPath)', '$([MSBuild]::NormalizePath('$(PackageOutputPath)', '$(PackageId).$(PackageVersion).nupkg'))'))"
RuntimeGraph="$(RuntimeIdentifierGraphPath)"
NoWarn="$(NoWarn)"
RunApiCompat="$([MSBuild]::ValueOrDefault('$(RunApiCompat)', 'true'))"
EnableStrictModeForCompatibleTfms="$([MSBuild]::ValueOrDefault('$(EnableStrictModeForCompatibleTfms)', 'true'))"
EnableStrictModeForCompatibleFrameworksInPackage="$([MSBuild]::ValueOrDefault('$(EnableStrictModeForCompatibleFrameworksInPackage)', 'false'))"
GenerateCompatibilitySuppressionFile="$(GenerateCompatibilitySuppressionFile)"
CompatibilitySuppressionFilePath="$(CompatibilitySuppressionFilePath)"
BaselinePackageTargetPath="$(PackageValidationBaselinePath)"
DisablePackageBaselineValidation="$(DisablePackageBaselineValidation)"/>
</Target>
<Import Project="$(MSBuildThisFileDirectory)Microsoft.NET.Compatibility.Common.targets" />
</Project>
4 changes: 0 additions & 4 deletions ...oft.DotNet.PackageValidation/buildMultiTargeting/Microsoft.DotNet.PackageValidation.props
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion ...t.DotNet.PackageValidation/buildMultiTargeting/Microsoft.DotNet.PackageValidation.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!-- Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license. -->
<Project>
<Import Project="$(MSBuildThisFileDirectory)..\build\$(MSBuildThisFile)" />
</Project>
</Project>
4 changes: 0 additions & 4 deletions src/Compatibility/Microsoft.DotNet.PackageValidation/sdk/Sdk.props
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions src/Compatibility/Microsoft.DotNet.PackageValidation/sdk/Sdk.targets
View file
Open in desktop

This file was deleted.

5 changes: 5 additions & 0 deletions src/Compatibility/Microsoft.DotNet.PackageValidation/xlf/Resources.cs.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@
<target state="new">Package '{0}' not found. Please provide a valid package path.</target>
<note />
</trans-unit>
<trans-unit id="UpdateSdkVersion">
<source> The minimum version required of Roslyn is '{1}' and you are using '{0}' version of the Roslyn. You can update the sdk to get the latest version.</source>
<target state="new"> The minimum version required of Roslyn is '{1}' and you are using '{0}' version of the Roslyn. You can update the sdk to get the latest version.</target>
<note />
</trans-unit>
<trans-unit id="WroteSuppressions">
<source>Successfully wrote compatibility suppressions to '{0}'.</source>
<target state="new">Successfully wrote compatibility suppressions to '{0}'.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Compatibility/Microsoft.DotNet.PackageValidation/xlf/Resources.de.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@
<target state="new">Package '{0}' not found. Please provide a valid package path.</target>
<note />
</trans-unit>
<trans-unit id="UpdateSdkVersion">
<source> The minimum version required of Roslyn is '{1}' and you are using '{0}' version of the Roslyn. You can update the sdk to get the latest version.</source>
<target state="new"> The minimum version required of Roslyn is '{1}' and you are using '{0}' version of the Roslyn. You can update the sdk to get the latest version.</target>
<note />
</trans-unit>
<trans-unit id="WroteSuppressions">
<source>Successfully wrote compatibility suppressions to '{0}'.</source>
<target state="new">Successfully wrote compatibility suppressions to '{0}'.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Compatibility/Microsoft.DotNet.PackageValidation/xlf/Resources.es.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@
<target state="new">Package '{0}' not found. Please provide a valid package path.</target>
<note />
</trans-unit>
<trans-unit id="UpdateSdkVersion">
<source> The minimum version required of Roslyn is '{1}' and you are using '{0}' version of the Roslyn. You can update the sdk to get the latest version.</source>
<target state="new"> The minimum version required of Roslyn is '{1}' and you are using '{0}' version of the Roslyn. You can update the sdk to get the latest version.</target>
<note />
</trans-unit>
<trans-unit id="WroteSuppressions">
<source>Successfully wrote compatibility suppressions to '{0}'.</source>
<target state="new">Successfully wrote compatibility suppressions to '{0}'.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Compatibility/Microsoft.DotNet.PackageValidation/xlf/Resources.fr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@
<target state="new">Package '{0}' not found. Please provide a valid package path.</target>
<note />
</trans-unit>
<trans-unit id="UpdateSdkVersion">
<source> The minimum version required of Roslyn is '{1}' and you are using '{0}' version of the Roslyn. You can update the sdk to get the latest version.</source>
<target state="new"> The minimum version required of Roslyn is '{1}' and you are using '{0}' version of the Roslyn. You can update the sdk to get the latest version.</target>
<note />
</trans-unit>
<trans-unit id="WroteSuppressions">
<source>Successfully wrote compatibility suppressions to '{0}'.</source>
<target state="new">Successfully wrote compatibility suppressions to '{0}'.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Compatibility/Microsoft.DotNet.PackageValidation/xlf/Resources.it.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@
<target state="new">Package '{0}' not found. Please provide a valid package path.</target>
<note />
</trans-unit>
<trans-unit id="UpdateSdkVersion">
<source> The minimum version required of Roslyn is '{1}' and you are using '{0}' version of the Roslyn. You can update the sdk to get the latest version.</source>
<target state="new"> The minimum version required of Roslyn is '{1}' and you are using '{0}' version of the Roslyn. You can update the sdk to get the latest version.</target>
<note />
</trans-unit>
<trans-unit id="WroteSuppressions">
<source>Successfully wrote compatibility suppressions to '{0}'.</source>
<target state="new">Successfully wrote compatibility suppressions to '{0}'.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Compatibility/Microsoft.DotNet.PackageValidation/xlf/Resources.ja.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@
<target state="new">Package '{0}' not found. Please provide a valid package path.</target>
<note />
</trans-unit>
<trans-unit id="UpdateSdkVersion">
<source> The minimum version required of Roslyn is '{1}' and you are using '{0}' version of the Roslyn. You can update the sdk to get the latest version.</source>
<target state="new"> The minimum version required of Roslyn is '{1}' and you are using '{0}' version of the Roslyn. You can update the sdk to get the latest version.</target>
<note />
</trans-unit>
<trans-unit id="WroteSuppressions">
<source>Successfully wrote compatibility suppressions to '{0}'.</source>
<target state="new">Successfully wrote compatibility suppressions to '{0}'.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Compatibility/Microsoft.DotNet.PackageValidation/xlf/Resources.ko.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@
<target state="new">Package '{0}' not found. Please provide a valid package path.</target>
<note />
</trans-unit>
<trans-unit id="UpdateSdkVersion">
<source> The minimum version required of Roslyn is '{1}' and you are using '{0}' version of the Roslyn. You can update the sdk to get the latest version.</source>
<target state="new"> The minimum version required of Roslyn is '{1}' and you are using '{0}' version of the Roslyn. You can update the sdk to get the latest version.</target>
<note />
</trans-unit>
<trans-unit id="WroteSuppressions">
<source>Successfully wrote compatibility suppressions to '{0}'.</source>
<target state="new">Successfully wrote compatibility suppressions to '{0}'.</target>
Expand Down
Loading