Skip to content

Conversation

tomwojcik
Copy link
Contributor

Fixes #32947

Although resolving the problem is very simple and probably won't result in any regressions, it'd require a very custom test case as shown in the ticket. Please let me know if the test case is required in such a case.

@github-actions
Copy link

Hello @tomwojcik! Thank you for your contribution 💪

As it's your first contribution be sure to check out the patch review checklist.

If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!

If you have any design or process questions then you can ask in the Django forum.

Welcome aboard ⛵️!

@felixxm
Copy link
Member

felixxm commented Jul 20, 2021

@tomwojcik Thanks for this patch 👍 Please add a release note (docs/releases/3.2.6.txt) and a regression test.

@tomwojcik
Copy link
Contributor Author

@tomwojcik Thanks for this patch Please add a release note (docs/releases/3.2.6.txt) and a regression test.

@felixxm I'm a bit overwhelmed today. If you don't mind I'll do this by Sunday.

@felixxm
Copy link
Member

felixxm commented Jul 20, 2021

@tomwojcik Thanks for this patch Please add a release note (docs/releases/3.2.6.txt) and a regression test.

@felixxm I'm a bit overwhelmed today. If you don't mind I'll do this by Sunday.

np, we can wait few days.

@tomwojcik
Copy link
Contributor Author

@felixxm I found some spare time today. Please let me know if my changes are sufficient.

Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomwojcik Thanks 👍 I left suggestions.

@felixxm felixxm changed the title Fixed #32947 -- make self.through_fields hashable if is type of list … Fixed #32947 -- Fixed hash() crash on reverse M2M relation when through_fields is a list. Jul 21, 2021
@tomwojcik
Copy link
Contributor Author

@tomwojcik Thanks I left suggestions.

Thanks! It all makes sense. I will make the necessary changes on Saturday.

@felixxm
Copy link
Member

felixxm commented Jul 26, 2021

@tomwojcik Thanks for updates 👍 Welcome aboard ⛵

@felixxm felixxm merged commit 20226fc into django:main Jul 26, 2021
@tomwojcik tomwojcik deleted the ticket_32947 branch July 26, 2021 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants