-
-
Notifications
You must be signed in to change notification settings - Fork 33.1k
Fixed #32947 -- Fixed hash() crash on reverse M2M relation when through_fields is a list. #14672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @tomwojcik! Thank you for your contribution 💪 As it's your first contribution be sure to check out the patch review checklist. If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket! If you have any design or process questions then you can ask in the Django forum. Welcome aboard ⛵️! |
@tomwojcik Thanks for this patch 👍 Please add a release note ( |
@felixxm I'm a bit overwhelmed today. If you don't mind I'll do this by Sunday. |
np, we can wait few days. |
@felixxm I found some spare time today. Please let me know if my changes are sufficient. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomwojcik Thanks 👍 I left suggestions.
Thanks! It all makes sense. I will make the necessary changes on Saturday. |
…gh_fields is a list. Regression in c32d8f3.
@tomwojcik Thanks for updates 👍 Welcome aboard ⛵ |
Fixes #32947
Although resolving the problem is very simple and probably won't result in any regressions, it'd require a very custom test case as shown in the ticket. Please let me know if the test case is required in such a case.