Skip to content

Conversation

@kmala
Copy link
Contributor

@kmala kmala commented Jun 5, 2016

minio removes the download links for the old releases.
curl doesn't detect if the link is broken and hence changed to ADD

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @krancour, @technosophos and @mboersma to be potential reviewers

@kmala kmala self-assigned this Jun 5, 2016
@kmala kmala added this to the v2.1-pre1 milestone Jun 5, 2016
@jchauncey jchauncey added the LGTM1 label Jun 5, 2016
@helgi
Copy link
Contributor

helgi commented Jun 5, 2016

We should mirror the releases we depend on

@kmala
Copy link
Contributor Author

kmala commented Jun 6, 2016

@helgi i was mistaken they don't totally remove the binary but move to a different location....so we have to use a different url to get the binary...

@kmala kmala force-pushed the rel branch 2 times, most recently from e265d24 to 53f82f1 Compare June 6, 2016 16:43
@arschles
Copy link
Member

arschles commented Jun 6, 2016

👍 on Helgi's comment. Let's put the Minio builds we need into S3 (or, since I'm a Google Cloud supporter, GCS!) and then ADD them here in the Dockerfile. Also, let's add a note in the README to explain that we mirror builds in S3

@bacongobbler bacongobbler mentioned this pull request Jun 6, 2016
@arschles
Copy link
Member

arschles commented Jun 6, 2016

Fixes #107

@bacongobbler
Copy link
Member

bacongobbler commented Jun 6, 2016

closes #107 (I believe only comments from issue and PR creators can close issues)

@kmala kmala merged commit 3f50543 into deis:master Jun 6, 2016
@kmala kmala deleted the rel branch June 6, 2016 18:07
@krancour krancour modified the milestones: v2.1, v2.1-pre1 Jun 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants