-
Notifications
You must be signed in to change notification settings - Fork 802
Non-breaking fixes #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Solomon Hykes <[email protected]>
Signed-off-by: Solomon Hykes <[email protected]>
vito
added a commit
that referenced
this pull request
Apr 25, 2023
* run dnsmasq in engine foreground, with debug logs Signed-off-by: Alex Suraci <[email protected]> * dnsmasq: use --keep-in-foreground rather than --no-daemon ...so that it still writes to the pidfile Signed-off-by: Alex Suraci <[email protected]> * redo atomic host file updates this wasn't really atomic before: it would _rename_ the live file, and then start writing to it. if dnsmasq itself tried to read the host file, it could either see that the file doesn't exist, or see a partially written file. now we'll write to a new path and then rename it over the live one, which is atomic. Signed-off-by: Alex Suraci <[email protected]> * clean up noisy dnsmasq red herring errors * create addnhosts file if not exists * set up upstream resolv.conf before starting dnsmasq Signed-off-by: Alex Suraci <[email protected]> * dnsmasq: don't configure bind-dynamic no idea why this was needed; it dates back to dnsname's initial commit. it seems to be causing dnsmasq to periodically stop listening and start listening again: #15 73.50 dnsmasq-debug[49]: stopped listening on dagger-dev0(#3): 10.88.0.1 port 53 #15 73.50 dnsmasq-debug[49]: listening on dagger-dev0(#3): 10.88.0.1 port 53 Signed-off-by: Alex Suraci <[email protected]> --------- Signed-off-by: Alex Suraci <[email protected]>
wingyplus
added a commit
to wingyplus/dagger
that referenced
this pull request
Jun 1, 2023
* Any function that accept *ID type must accept proper type instead. * Add typespec to Enum functions. Closes dagger#15
gerhard
added a commit
that referenced
this pull request
Jun 1, 2023
* Initial project * Construct client and perform query. * Implement engine connection to find connection to Dagger. * Add query builder to build graphql query and select data from response. * Handle error when fetching Dagger session * Remove unused field and asserting type in Selection.build/1 * Remove unused code * Generate code from GraphQL introspection Closes #3 * Ensure first argument match with the module Prevent accidentally chain function by pattern match with module. * Change version to 0.1.0-dev * Generate document for functions * Use field name from introspection not from function name * Render deprecate functions * Extract format doc to function * Eliminate arg to_string conversion * Add required & optional arguments to function doc * Add ex_doc * Do not export Dagger.Codegen.Compiler to doc * Add tutorial through livebook * Fix argument not convert to snake case in doc * Running dagger via dagger session * Add experiment env to Livebook tutorial * Rename opts to args `args` is make sense since it's arguments of graph api not options. * Update README.md * Create ci.yml * Rework on obtaining session Create a session module for talking with `dagger session` which's start in a new process. The session accept the EngineConn pid for passing the session info and logger function to print log line after session is comming. * Support graceful disconnect from dagger session * Add mix task to run test with dagger * Rework on GitHub CI * Rename dagger to dagger-cue on GitHub Workflow * Try install Dagger manually * Use curl instead of wget * Fix path extraction * Do not do anything with session env disconnect * Show dagger version in GitHub Workflow * Fix invalid env variable * Fix invalid env variable * Rename lib/mix/task to lib/mix/tasks * Eliminate to_string conversion for optional argument Fixes #12 * Revert "Eliminate to_string conversion for optional argument" This reverts commit ae5fc7cb35e96e4cc84571b491bf0fe3184bf444. * Support custom timeout via Dagger.connect/1 * Fix query builder argument not adding comma separator * Rework on optional args code generation Fixes: #12 * Refactor how render function * Add `Dagger.Codegen.Elixir.Function.define/4`. * Refactor in `Dagger.Codegen.Elixir.Templates.ObjectTmpl` to define via `Function.define/4` instead. * Refactor function rendering * Rename `format_function` to `format_function_body`. * Refactor how format function name. * Move doc generation to Function.define/5 * Move deprecated generation to Function.define/5 * Refactor required arg verification * Change function signature code generation * Add Dagger.Codegen.Elixir.Function tests * Remove get variable name from type * Check formatting in CI * Refactor arguments doc generation * Remove `.` in deprecated reason * Prepare 0.1.0 * Add donation badge * Prepare 0.1.0 round 2 * Generate a new code from Dagger 0.5.1 * Fix crash on Dagger 0.5.1 Skip `Connected to engine...` message before session comes in. * Fix source reference not presents in docs And include CHANGELOG in the Hex.pm page. * Prepare 0.1.1 * Prepare 0.1.1 round 2 * Generate scalar type and no explict get id before pass to function Closes #7 Closes #13 * Run unit test and check format concurrently * Generate enum types Closes #8 * Change version * Generate type spec for object and enum types * Refactor format module name * Fix incorrect type generation * Any function that accept *ID type must accept proper type instead. * Add typespec to Enum functions. Closes #15 * Add v0.2.0 CHANGELOG * Optimize context transfer in CI test * Experiment with_session/2 in mix ci.test * Add connect schema * Add connect schema to conform SDK guide specification. * Separate connect timeout and query timeout. * Add TODOs. * Move connect schema to Dagger.Client * Implement download CLI (#22) Recheck the CLI in `$XDG_CACHE_HOME` before start downloading. If binary exists, use that binary, otherwise, download it from dagger site. * Remove IO.puts in mix ci.test * Do not swallow dagger connect message * Returns error when execute graphql query * Rename ci.test to dagger.ci.test * Refactor filter type mechanism * Move Dagger.Codegen.Compiler to new file * Attach module name into introspection type and regenerate code * Add Rewrite into compile pipeline * Use mod_name in private instead of using from name And re-generate code. * Rename Rewrite module to Mutator * Add mutator test * Rename Dagger.disconnect/1 to Dagger.close/1 Updates #18 * Move Dagger.Client into Dagger.Internal * Add option during call dagger session * Add `:workdir` into `dagger session`. * Remove `:config_path`. * Cleanup `:log_output` to accept device uses by `IO.binwrite/2`. * Use `IO.binwrite/2` instead of `IO.write/2`. Closes #28 * Bump dagger to 0.5.3 and re-generate code * Update dagger to 0.6.0 * Bump CI to use dagger 0.6.0 * Fix code gen for ProjectID and ProjectCommandID * Import wingyplus/dagger_ex into sdk/elixir subdir Signed-off-by: Gerhard Lazu <[email protected]> * Add experimental warning to README Signed-off-by: Gerhard Lazu <[email protected]> * Update GitHub URL & fix path in package info Signed-off-by: Gerhard Lazu <[email protected]> * Add /sdk/elixir to CODEOWNERS Signed-off-by: Gerhard Lazu <[email protected]> * Remove rename_query_type mutator This is still in complete and make test failures. So remove it. Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]> * Make mix dagger.ci.test exit non-zero status code when test failures Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]> * Implement ./hack/make sdk:elixir:test and add it to CI Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]> * Allow to configure Elixir/OTP version And change Sync to ExitCode. Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]> * Implement ./hack/make sdk:elixir:lint and add it to CI Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]> * Remove sdk/elixir/.github Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]> * Remove sdk/elixir/lib/mix/tasks/dagger.ci.test.exs It already ported to ./hack/make sdk:elixir:[test,lint] Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]> * Fix pipeline should be elixir, not go Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]> * Change source url and changelog url Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]> * Add sdk:elixir tasks description Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]> * Fix incorrect pipeline name in sdk:elixir:lint task Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]> * ci: implement sdk:elixir:generate Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]> * Extract versions in constants So that they are declared only once - single replace when needed. Signed-off-by: Gerhard Lazu <[email protected]> * Fix sdk/elixir gitignores They are not repository top-level. Signed-off-by: Gerhard Lazu <[email protected]> --------- Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]> Co-authored-by: Gerhard Lazu <[email protected]>
vikram-dagger
pushed a commit
to vikram-dagger/dagger
that referenced
this pull request
Aug 6, 2025
Add missing module structure content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various non-breaking fixes, grouped in a single PR to save time.
source
.