Import Elixir SDK as Experimental #5201

gerhard · 2023-05-25T18:43:19Z

This imports https://github.com/wingyplus/dagger_ex under sdk/elixir as an experimental SDK.

@gerhard action items (part of this PR)

Open PR with https://github.com/wingyplus/dagger_ex history import
- Capture commands used for history import

git remote add dagger-sdk-elixir [email protected]:wingyplus/dagger_ex
git fetch dagger-sdk-elixir --no-tags
git checkout -b sdk/elixir dagger-sdk-elixir/main
mkdir -p sdk/elixir
git ls-tree -z --name-only HEAD | xargs -0 -I {} git mv {} sdk/elixir/
git commit --gpg-sign --signoff

git checkout main
git pull
git checkout -b import-sdk-elixir

git merge --gpg-sign --signoff --allow-unrelated-histories sdk/elixir

git push -u fork

Give @wingyplus write permissions to dagger repository
Add @wingyplus to CODEOWNERS (@dagger/sdk-elixir group)
- If we like this, I propose that we do the same for other SDKs cc @shykes @samalba @aluzzardi
Mention in SDK's README that Elixir is currently experimental

@wingyplus action items (part of this PR)

Configure Sign-off-by https://docs.dagger.io/204441/contributing/#dco
- @gerhard manually set this to Pass so that @wingyplus does not need to rewrite 255 commits
Move (and rename) GHA workflows from sdk/elixir/.github to .github/
Ensure all GHA workflows pass

Follow-ups (outside / after this PR)

This sounds like maintainer on-boarding to me @wingyplus 🙂

Migrate open issues which are still relevant - 10 open currently
- Ensure that we have a new sdk/elixir label cc @d3rp3tt3 @mircubed
Migrate PRs which are still relevant
Add commit to https://github.com/wingyplus/dagger_ex that removes all files except the README
- Add repo migration notice to README.md
- Archive repository in GitHub, e.g. https://github.com/thechangelog/infrastructure
Tag sdk/elixir/v* to check that a new release gets created as expected
- This will require us to check that all three crates are published by Dagger. FTR: https://www.hex.pm/packages/dagger_ex - maybe rename to https://www.hex.pm/packages/dagger
Add Elixir SDK to https://github.com/dagger/dagger/blob/main/RELEASING.md
- cc @gerhard
Integrate with Analytics
- cc @grouville @d3rp3tt3

Did I miss anything @shykes @samalba @wingyplus @d3rp3tt3 @mircubed?

kjuulh · 2023-05-25T19:10:50Z

Looks good from my pov. I guess the next steps would be adopting the hack/ scripts and integrating ci?

kjuulh · 2023-05-25T19:16:30Z

FYI I am not quite sure why I am tagged xD

wingyplus · 2023-05-26T04:36:47Z

Note for myself:

Fix tests failure
Fix mix dagger.ci to return the proper exit code. Currently, it still passes even tests that are failures.
Integrate ci to dagger. Never looked in the dagger repo but sounds fun. :D
- Test (https://github.com/dagger/dagger/actions/runs/5093616869/jobs/9156443707?pr=5201)
- Lint (https://github.com/dagger/dagger/actions/runs/5093693421/jobs/9156616134?pr=5201)
- Generate
- Publish
- Bump

wingyplus · 2023-05-26T18:11:35Z

Hi @gerhard,

I've done porting sdk/elixir/.github into .github and ported the test and lint pipeline into internal/mage/sdk already. I'm not sure about 3 mage tasks left (~~generate~~, bump, publish), do I need to tackle in this PR or do it later?

sdk/elixir/mix.exs

gerhard · 2023-05-30T18:01:26Z

@kjuulh FYI I am not quite sure why I am tagged xD

My mistake, it's OK to unfollow this PR 👍

gerhard · 2023-05-30T18:04:39Z

I've done porting sdk/elixir/.github into .github and ported the test and lint pipeline into internal/mage/sdk already.

🙌 @wingyplus. I will be checking the state of this PR shortly.

I'm not sure about 3 mage tasks left (~~generate~~, bump, publish), do I need to tackle in this PR or do it later?

All of these can be done in follow-up PRs, no worries.

gerhard · 2023-05-30T18:32:16Z

All the changes look good to me.

Would you like to rebase everything on top of main before we merge @wingyplus?

After you do that, if everything looks good to you, please approve the PR @wingyplus so that we can get it merged 💪

wingyplus · 2023-06-01T05:03:58Z

@gerhard The PR is now rebased. And all tests related to Elixir are now passed except test / engine which seems not related to this PR and DCO check. 🙇

* Construct client and perform query. * Implement engine connection to find connection to Dagger. * Add query builder to build graphql query and select data from response.

Closes #3

Prevent accidentally chain function by pattern match with module.

* Add `:workdir` into `dagger session`. * Remove `:config_path`. * Cleanup `:log_output` to accept device uses by `IO.binwrite/2`. * Use `IO.binwrite/2` instead of `IO.write/2`. Closes #28

Signed-off-by: Gerhard Lazu <[email protected]>

This is still in complete and make test failures. So remove it. Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

And change Sync to ExitCode. Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

It already ported to ./hack/make sdk:elixir:[test,lint] Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

So that they are declared only once - single replace when needed. Signed-off-by: Gerhard Lazu <[email protected]>

They are not repository top-level. Signed-off-by: Gerhard Lazu <[email protected]>

wingyplus · 2023-06-01T17:34:37Z

Rebase again

wingyplus · 2023-06-01T17:48:54Z

I found lint-daggerized workflow error due to pointing to incorrect local action (ref https://github.com/dagger/dagger/actions/runs/5147441125). I sent a fix here #5244.

gerhard · 2023-06-01T18:34:19Z

Set DCO to pass.

Engine test is a flake - re-running the test.

When all checks pass, this will be merged. Thank you for sticking with this @wingyplus!

wingyplus reviewed May 26, 2023

View reviewed changes

sdk/elixir/mix.exs Outdated Show resolved Hide resolved

wingyplus force-pushed the import-sdk-elixir branch from e3d05e7 to a822bbf Compare June 1, 2023 03:24

wingyplus approved these changes Jun 1, 2023

View reviewed changes

wingyplus added 19 commits June 2, 2023 00:33

Initial project

83a2ebb

* Construct client and perform query. * Implement engine connection to find connection to Dagger. * Add query builder to build graphql query and select data from response.

Handle error when fetching Dagger session

2d50ad1

Remove unused field and asserting type in Selection.build/1

d69fca2

Remove unused code

c5ff730

Generate code from GraphQL introspection

93d003f

Closes #3

Ensure first argument match with the module

43c50c9

Prevent accidentally chain function by pattern match with module.

Change version to 0.1.0-dev

1b2234e

Generate document for functions

4892f7d

Use field name from introspection not from function name

05e4756

Render deprecate functions

7c565eb

Extract format doc to function

06688b4

Eliminate arg to_string conversion

a763cc8

Add required & optional arguments to function doc

28df2ec

Add ex_doc

b32666b

Do not export Dagger.Codegen.Compiler to doc

dea3c86

Add tutorial through livebook

bbdc91a

Fix argument not convert to snake case in doc

7bf1686

Running dagger via dagger session

9281f77

Add experiment env to Livebook tutorial

efb36f3

wingyplus and others added 23 commits June 2, 2023 00:33

Add option during call dagger session

b709df8

* Add `:workdir` into `dagger session`. * Remove `:config_path`. * Cleanup `:log_output` to accept device uses by `IO.binwrite/2`. * Use `IO.binwrite/2` instead of `IO.write/2`. Closes #28

Bump dagger to 0.5.3 and re-generate code

0f3fee9

Update dagger to 0.6.0

784a440

Bump CI to use dagger 0.6.0

943caa0

Fix code gen for ProjectID and ProjectCommandID

93ae8bf

Import wingyplus/dagger_ex into sdk/elixir subdir

7933613

Signed-off-by: Gerhard Lazu <[email protected]>

Add experimental warning to README

22137ec

Signed-off-by: Gerhard Lazu <[email protected]>

Update GitHub URL & fix path in package info

87da081

Signed-off-by: Gerhard Lazu <[email protected]>

Add /sdk/elixir to CODEOWNERS

867bebe

Signed-off-by: Gerhard Lazu <[email protected]>

Remove rename_query_type mutator

bd756e2

This is still in complete and make test failures. So remove it. Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

Make mix dagger.ci.test exit non-zero status code when test failures

7a23176

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

Implement ./hack/make sdk:elixir:test and add it to CI

c67cca9

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

Allow to configure Elixir/OTP version

e67ad35

And change Sync to ExitCode. Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

Implement ./hack/make sdk:elixir:lint and add it to CI

9c65f06

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

Remove sdk/elixir/.github

28b6708

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

Remove sdk/elixir/lib/mix/tasks/dagger.ci.test.exs

a770fb7

It already ported to ./hack/make sdk:elixir:[test,lint] Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

Fix pipeline should be elixir, not go

a718106

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

Change source url and changelog url

e194425

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

Add sdk:elixir tasks description

d9abf8a

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

Fix incorrect pipeline name in sdk:elixir:lint task

5163a0a

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

ci: implement sdk:elixir:generate

88c602e

Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>

Extract versions in constants

e6adff0

So that they are declared only once - single replace when needed. Signed-off-by: Gerhard Lazu <[email protected]>

Fix sdk/elixir gitignores

b7f69e5

They are not repository top-level. Signed-off-by: Gerhard Lazu <[email protected]>

wingyplus force-pushed the import-sdk-elixir branch from a822bbf to b7f69e5 Compare June 1, 2023 17:34

gerhard merged commit 100b99d into dagger:main Jun 1, 2023

gerhard deleted the import-sdk-elixir branch June 1, 2023 18:47

wingyplus mentioned this pull request Jun 2, 2023

sdk: Bump engine dependency to v0.6.1 #5268

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Import Elixir SDK as Experimental #5201

Import Elixir SDK as Experimental #5201

Uh oh!

gerhard commented May 25, 2023 •

edited

Loading

Uh oh!

kjuulh commented May 25, 2023

Uh oh!

kjuulh commented May 25, 2023

Uh oh!

wingyplus commented May 26, 2023 •

edited

Loading

Uh oh!

wingyplus commented May 26, 2023 •

edited

Loading

Uh oh!

Uh oh!

gerhard commented May 30, 2023 •

edited

Loading

Uh oh!

gerhard commented May 30, 2023 •

edited

Loading

Uh oh!

gerhard commented May 30, 2023

Uh oh!

wingyplus commented Jun 1, 2023 •

edited

Loading

Uh oh!

wingyplus commented Jun 1, 2023 •

edited

Loading

Uh oh!

wingyplus commented Jun 1, 2023

Uh oh!

gerhard commented Jun 1, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Import Elixir SDK as Experimental #5201

Import Elixir SDK as Experimental #5201

Uh oh!

Conversation

gerhard commented May 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

@gerhard action items (part of this PR)

@wingyplus action items (part of this PR)

Follow-ups (outside / after this PR)

Uh oh!

kjuulh commented May 25, 2023

Uh oh!

kjuulh commented May 25, 2023

Uh oh!

wingyplus commented May 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wingyplus commented May 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

gerhard commented May 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gerhard commented May 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gerhard commented May 30, 2023

Uh oh!

wingyplus commented Jun 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wingyplus commented Jun 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wingyplus commented Jun 1, 2023

Uh oh!

gerhard commented Jun 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gerhard commented May 25, 2023 •

edited

Loading

wingyplus commented May 26, 2023 •

edited

Loading

wingyplus commented May 26, 2023 •

edited

Loading

gerhard commented May 30, 2023 •

edited

Loading

gerhard commented May 30, 2023 •

edited

Loading

wingyplus commented Jun 1, 2023 •

edited

Loading

wingyplus commented Jun 1, 2023 •

edited

Loading

gerhard commented Jun 1, 2023 •

edited

Loading