Skip to content

Partial revert of #9624: test seemed to cause some memory leaks in CI #9660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2023
Merged

Partial revert of #9624: test seemed to cause some memory leaks in CI #9660

merged 1 commit into from
Nov 13, 2023
+0 −49

Conversation

@carlopi
Copy link
Contributor

@carlopi carlopi commented Nov 13, 2023 •
edited
Loading

To be reviewed re-adding this test in some other version.

Node that interrupt functionality, that was the core of the PR, has been left untouched.

@carlopi
Partial revert of duckdb#9624: test seemed to cause some memory leaks…
8bcd34b 
… in CI runs

To be reviewed readding this test in some other version
@carlopi carlopi requested a review from Mytherin November 13, 2023 16:15
Mytherin
Mytherin approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@Mytherin Mytherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@Mytherin Mytherin merged commit 3c695d7 into duckdb:main Nov 13, 2023
@carlopi carlopi deleted the removeflakytest branch November 13, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mytherin Mytherin Mytherin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@carlopi @Mytherin