allow dbgen to be interrupted by user #9624
Merged
+55
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks! LGTM |
carlopi
added a commit
to carlopi/duckdb
that referenced
this pull request
Nov 13, 2023
… in CI runs To be reviewed readding this test in some other version
Mytherin
added a commit
that referenced
this pull request
Nov 13, 2023
Partial revert of #9624: test seemed to cause some memory leaks in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
dbgen()is not interruptible by the user. This PR adds interruptability by passing the context togen_tbl()function and occasionally checking for context interrupt.cc: @ywelsch