-
Notifications
You must be signed in to change notification settings - Fork 1.1k
OCPBUGS-69670: [release-1.33] : Ensure InitLabel only sets process label when unset #9674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-69670: [release-1.33] : Ensure InitLabel only sets process label when unset #9674
Conversation
Signed-off-by: Ayato Tokubi <[email protected]> (cherry picked from commit 4e2f7db) Signed-off-by: Ayato Tokubi <[email protected]> # Conflicts: # server/container_create.go
|
@openshift-cherrypick-robot: Could not make automatic cherrypick of Jira Issue OCPBUGS-69669 for this PR as the target version is not set for this branch in the jira plugin config. Running refresh: /retitle [release-1.33] : Ensure InitLabel only sets process label when unset DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@openshift-ci-robot: This pull request references Jira Issue OCPBUGS-69669, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: No Jira issue is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-1.33 #9674 +/- ##
================================================
- Coverage 49.54% 49.54% -0.01%
================================================
Files 164 164
Lines 18319 18320 +1
================================================
- Hits 9077 9076 -1
- Misses 8104 8106 +2
Partials 1138 1138 🚀 New features to boost your workflow:
|
|
/retest |
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-69670, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-1.32 |
|
@bitoku: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
/jira refresh |
|
@bitoku: This pull request references Jira Issue OCPBUGS-69670, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
I thought lgtm adds lgtm and approved label, but it didn't. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9fc7369
into
cri-o:release-1.33
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-69670: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-69670 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@bitoku: #9674 failed to apply on top of branch "release-1.32": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #9671
/assign openshift-ci-robot