OCPBUGS-69669: [release-1.34] Ensure InitLabel only sets process label when unset #9671

bitoku · 2025-12-17T12:08:20Z

What type of PR is this?

/kind bug

What this PR does / why we need it:

cherry pick from #9666

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Respect user specified selinux label for systemd or init container.

Signed-off-by: Ayato Tokubi <[email protected]> (cherry picked from commit 4e2f7db) Signed-off-by: Ayato Tokubi <[email protected]> # Conflicts: # server/container_create.go

coderabbitai · 2025-12-17T12:08:28Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci-robot · 2025-12-17T12:08:28Z

@bitoku: This pull request references Jira Issue OCPBUGS-69669, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected dependent Jira Issue OCPBUGS-69402 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

cherry pick from #9666

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?
Respect user specified selinux label for systemd or init container. 

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

bitoku · 2025-12-17T12:08:50Z

/jira backport release-1.33

openshift-ci-robot · 2025-12-17T12:08:55Z

@bitoku: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-1.33

Details

In response to this:

/jira backport release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2025-12-17T12:08:57Z

@openshift-ci-robot: once the present PR merges, I will cherry-pick it on top of release-1.33 in a new PR and assign it to you.

Details

In response to this:

@bitoku: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-1.33

In response to this:

/jira backport release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

bitoku · 2025-12-17T12:10:10Z

/jira backport release-4.20

openshift-ci-robot · 2025-12-17T12:10:13Z

@bitoku: Missing required branches for backport chain:

release-4.21 OR openshift-4.21,

Details

In response to this:

/jira backport release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

bitoku · 2025-12-17T12:12:54Z

/jira backport release-4.21,release-4.20,release-4.19,release-4.18,release-4.17

openshift-ci-robot · 2025-12-17T12:12:58Z

@bitoku: Missing required branches for backport chain:

release-4.22 OR main OR openshift-4.22 OR master,

Details

In response to this:

/jira backport release-4.21,release-4.20,release-4.19,release-4.18,release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

bitoku · 2025-12-17T12:23:55Z

/cherry-pick release-1.33

openshift-cherrypick-robot · 2025-12-17T12:23:57Z

@bitoku: once the present PR merges, I will cherry-pick it on top of release-1.33 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2025-12-17T15:03:08Z

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.18%. Comparing base (aeecf5d) to head (d7d317c).
⚠️ Report is 2 commits behind head on release-1.34.

Additional details and impacted files

@@               Coverage Diff                @@
##           release-1.34    #9671      +/-   ##
================================================
- Coverage         64.23%   64.18%   -0.05%     
================================================
  Files               202      202              
  Lines             28225    28229       +4     
================================================
- Hits              18130    18120      -10     
- Misses             8502     8516      +14     
  Partials           1593     1593

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

haircommander · 2025-12-17T16:06:42Z

/lgtm
/approve

openshift-ci · 2025-12-17T16:06:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bitoku, haircommander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [haircommander]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2025-12-17T16:10:23Z

@bitoku: Jira Issue OCPBUGS-69669: All pull requests linked via external trackers have merged:

cri-o/cri-o#9671

Jira Issue OCPBUGS-69669 has been moved to the MODIFIED state.

Details

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

cherry pick from #9666

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?
Respect user specified selinux label for systemd or init container. 

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2025-12-17T16:11:05Z

@openshift-ci-robot: new pull request created: #9674

Details

In response to this:

@bitoku: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-1.33

In response to this:

/jira backport release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Ensure InitLabel only sets process label when unset

d7d317c

Signed-off-by: Ayato Tokubi <[email protected]> (cherry picked from commit 4e2f7db) Signed-off-by: Ayato Tokubi <[email protected]> # Conflicts: # server/container_create.go

bitoku requested a review from mrunalp as a code owner December 17, 2025 12:08

openshift-ci bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 17, 2025

openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Dec 17, 2025

openshift-ci bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Dec 17, 2025

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 17, 2025

openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 17, 2025

openshift-ci bot requested review from QiWang19 and klihub December 17, 2025 12:08

openshift-ci bot assigned haircommander Dec 17, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2025

openshift-merge-bot bot merged commit babcd43 into cri-o:release-1.34 Dec 17, 2025
52 of 55 checks passed

openshift-cherrypick-robot mentioned this pull request Dec 17, 2025

OCPBUGS-69670: [release-1.33] : Ensure InitLabel only sets process label when unset #9674

Open

OCPBUGS-69669: [release-1.34] Ensure InitLabel only sets process label when unset #9671

OCPBUGS-69669: [release-1.34] Ensure InitLabel only sets process label when unset #9671

Uh oh!

Conversation

bitoku commented Dec 17, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Uh oh!

coderabbitai bot commented Dec 17, 2025

Review skipped

Uh oh!

openshift-ci-robot commented Dec 17, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Uh oh!

bitoku commented Dec 17, 2025

Uh oh!

openshift-ci-robot commented Dec 17, 2025

Uh oh!

openshift-cherrypick-robot commented Dec 17, 2025

Uh oh!

bitoku commented Dec 17, 2025

Uh oh!

openshift-ci-robot commented Dec 17, 2025

Uh oh!

bitoku commented Dec 17, 2025

Uh oh!

openshift-ci-robot commented Dec 17, 2025

Uh oh!

bitoku commented Dec 17, 2025

Uh oh!

openshift-cherrypick-robot commented Dec 17, 2025

Uh oh!

codecov bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

haircommander commented Dec 17, 2025

Uh oh!

openshift-ci bot commented Dec 17, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Dec 17, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Uh oh!

openshift-cherrypick-robot commented Dec 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Dec 17, 2025 •

edited

Loading