Skip to content

WIP: [1.32] container: filter thermal_throttle masked paths #9661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saschagrunert wants to merge 1 commit into
base: release-1.32
Choose a base branch
from
Open

WIP: [1.32] container: filter thermal_throttle masked paths #9661

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion internal/factory/container/container.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -798,7 +798,8 @@ func (c *container) SpecSetPrivileges(ctx context.Context, securityContext *type

if !c.Privileged() {
if securityContext.MaskedPaths != nil {
for _, path := range securityContext.MaskedPaths {
filteredPaths := filterThermalThrottlePaths(securityContext.MaskedPaths)
for _, path := range filteredPaths {
specgen.AddLinuxMaskedPaths(path)
}
}
Expand Down Expand Up @@ -864,3 +865,22 @@ func (c *container) SpecSetLinuxContainerResources(resources *types.LinuxContain
}
return nil
}

// filterThermalThrottlePaths removes thermal_throttle masked paths to prevent
// severe performance degradation on high-CPU count systems.
func filterThermalThrottlePaths(paths []string) []string {
const thermalThrottlePrefix = "/sys/devices/system/cpu/cpu"
const thermalThrottleSuffix = "/thermal_throttle"

result := make([]string, 0, len(paths))

for _, path := range paths {
// Skip thermal_throttle paths to avoid mount explosion
if strings.HasPrefix(path, thermalThrottlePrefix) && strings.HasSuffix(path, thermalThrottleSuffix) {
continue
}
result = append(result, path)
}

return result
}
Loading