Skip to content

WIP: [1.32] container: filter thermal_throttle masked paths #9661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
saschagrunert wants to merge 1 commit into
base: release-1.32
Choose a base branch
from
Open

WIP: [1.32] container: filter thermal_throttle masked paths #9661

saschagrunert wants to merge 1 commit into from
+21 −1

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Dec 15, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Filter thermal_throttle paths from kubelet to fix performance regression on high-CPU bare metal systems during mass pod deployments.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Refers to https://issues.redhat.com/browse/OCPBUGS-66238

Does this PR introduce a user-facing change?

None

@saschagrunert
container: filter thermal_throttle masked paths
88ecc78 
Filter thermal_throttle paths from kubelet to fix performance regression
on high-CPU bare metal systems during mass pod deployments.

Signed-off-by: Sascha Grunert <[email protected]>
@openshift-ci openshift-ci bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 15, 2025
@coderabbitai
Copy link

coderabbitai bot commented Dec 15, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 15, 2025
@openshift-ci openshift-ci bot requested review from QiWang19 and hasan4791 December 15, 2025 08:26
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2025
@saschagrunert saschagrunert changed the title [1.32] container: filter thermal_throttle masked paths WIP: [1.32] container: filter thermal_throttle masked paths Dec 15, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 15, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2025

@saschagrunert: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn 88ecc78 link true /test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

❌ Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.87%. Comparing base (2fd6ad6) to head (88ecc78).

Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.32    #9661      +/-   ##
================================================
+ Coverage         48.85%   48.87%   +0.02%     
================================================
  Files               155      155              
  Lines             17570    17580      +10     
================================================
+ Hits               8584     8593       +9     
  Misses             7917     7917              
- Partials           1069     1070       +1
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@hasan4791 hasan4791 Awaiting requested review from hasan4791

@QiWang19 QiWang19 Awaiting requested review from QiWang19

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@saschagrunert