Add additional bind mount to image volumes #8521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8521 +/- ##
==========================================
- Coverage 49.35% 49.25% -0.10%
==========================================
Files 153 153
Lines 17206 17254 +48
==========================================
+ Hits 8492 8499 +7
- Misses 7648 7687 +39
- Partials 1066 1068 +2 |
carlory
reviewed
Aug 26, 2024
saschagrunert
commented
Aug 26, 2024
aa7b6d5 to
5c5f785
Compare
saschagrunert
commented
Aug 27, 2024
|
/retest |
b05101a to
68f3aa3
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
8092ef2 to
fcdef6b
Compare
|
/retest @cri-o/cri-o-maintainers PTAL |
|
/retest |
fcdef6b to
d791d0d
Compare
|
/retest |
|
@cri-o/cri-o-maintainers PTAL, CI is green |
kwilczynski
reviewed
Aug 28, 2024
This should allow using different SELinux contexts if multiple pods use a single image. Signed-off-by: Sascha Grunert <[email protected]>
d791d0d to
9ad5c5a
Compare
|
/approve |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kwilczynski, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This should allow using different SELinux contexts if multiple pods use a single image.
Inherited from 61d4a59#diff-1e0877112035840d3e2f073c693665f8daffa241a440e54a866ad7382b510ea2R1240
Which issue(s) this PR fixes:
Follow-up on #8317
Refers to:
Special notes for your reviewer:
/hold
This needs to be well tested.
Does this PR introduce a user-facing change?