Skip to content

Add OCI/Image Volume Source support #8317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2024
Merged

Add OCI/Image Volume Source support #8317

merged 1 commit into from
Jul 19, 2024

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Jun 24, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adding support for the new OCI Volume Source feature.

Which issue(s) this PR fixes:

Refers to kubernetes/enhancements#4639

Special notes for your reviewer:

Requires kubernetes/kubernetes#125659

Does this PR introduce a user-facing change?

Added support for the Kubernetes OCI / image Volume Source ([KEP-4639](https://github.com/kubernetes/enhancements/issues/4639)).

@saschagrunert saschagrunert requested a review from mrunalp as a code owner June 24, 2024 09:39
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jun 24, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2024
@saschagrunert saschagrunert force-pushed the oci-volumesource-cri-o branch from 51c2410 to 2936624 Compare June 24, 2024 09:41
@saschagrunert saschagrunert mentioned this pull request Jun 24, 2024
Open
14 tasks
@saschagrunert saschagrunert force-pushed the oci-volumesource-cri-o branch 3 times, most recently from 6d0d8d7 to 353c86a Compare June 25, 2024 10:20
@codecov
Copy link

codecov bot commented Jun 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 25.92593% with 40 lines in your changes missing coverage. Please review.

Project coverage is 49.43%. Comparing base (043cae7) to head (c39e801).
Report is 16 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8317      +/-   ##
==========================================
- Coverage   49.53%   49.43%   -0.10%     
==========================================
  Files         153      153              
  Lines       17088    17134      +46     
==========================================
+ Hits         8464     8470       +6     
- Misses       7559     7595      +36     
- Partials     1065     1069       +4

@saschagrunert saschagrunert force-pushed the oci-volumesource-cri-o branch 5 times, most recently from c6a3c99 to e65e8e6 Compare June 26, 2024 10:18
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 27, 2024
@saschagrunert saschagrunert force-pushed the oci-volumesource-cri-o branch 2 times, most recently from 99336ac to 4e0f15b Compare June 28, 2024 08:50
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 28, 2024
@saschagrunert saschagrunert force-pushed the oci-volumesource-cri-o branch from 4e0f15b to 78b7783 Compare July 2, 2024 08:09
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 2, 2024
@saschagrunert saschagrunert force-pushed the oci-volumesource-cri-o branch from 78b7783 to e62584b Compare July 2, 2024 08:16
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 2, 2024
@saschagrunert saschagrunert force-pushed the oci-volumesource-cri-o branch 3 times, most recently from cb1fcd8 to 61d4a59 Compare July 3, 2024 12:29
@saschagrunert
Copy link
Member Author

/retest

@saschagrunert
Copy link
Member Author

/test ci-cgroupv2-integration

1 similar comment
@saschagrunert
Copy link
Member Author

/test ci-cgroupv2-integration

@kwilczynski
Copy link
Contributor

/retest

3 similar comments
@kwilczynski
Copy link
Contributor

/retest

@saschagrunert
Copy link
Member Author

/retest

@saschagrunert
Copy link
Member Author

/retest

@saschagrunert
Copy link
Member Author

/override ci/prow/ci-fedora-integration
/override ci/prow/ci-cgroupv2-integration
/override ci/prow/ci-fedora-kata

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2024

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-cgroupv2-integration, ci/prow/ci-fedora-integration, ci/prow/ci-fedora-kata

In response to this:

/override ci/prow/ci-fedora-integration
/override ci/prow/ci-cgroupv2-integration
/override ci/prow/ci-fedora-kata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@saschagrunert
Copy link
Member Author

/override ci/prow/ci-fedora-integration
/override ci/prow/ci-cgroupv2-integration
/override ci/prow/ci-fedora-kata

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2024

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-cgroupv2-integration, ci/prow/ci-fedora-integration, ci/prow/ci-fedora-kata

In response to this:

/override ci/prow/ci-fedora-integration
/override ci/prow/ci-cgroupv2-integration
/override ci/prow/ci-fedora-kata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@saschagrunert
Copy link
Member Author

/retest

@saschagrunert
Copy link
Member Author

/override ci/prow/e2e-gcp-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2024

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/e2e-gcp-ovn

In response to this:

/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@saschagrunert
Copy link
Member Author

/override ci/prow/e2e-gcp-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2024

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/e2e-gcp-ovn

In response to this:

/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@saschagrunert
Copy link
Member Author

/retest

@saschagrunert
Copy link
Member Author

/override ci/prow/ci-fedora-integration

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2024

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-fedora-integration

In response to this:

/override ci/prow/ci-fedora-integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@saschagrunert
Copy link
Member Author

/override ci/prow/ci-fedora-integration
/override ci/prow/ci-cgroupv2-integration
/override ci/prow/ci-fedora-kata

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2024

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-cgroupv2-integration, ci/prow/ci-fedora-integration, ci/prow/ci-fedora-kata

In response to this:

/override ci/prow/ci-fedora-integration
/override ci/prow/ci-cgroupv2-integration
/override ci/prow/ci-fedora-kata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 6cc20ab into cri-o:main Jul 19, 2024
@saschagrunert saschagrunert deleted the oci-volumesource-cri-o branch July 19, 2024 08:56
@littlejawa littlejawa mentioned this pull request Jul 22, 2024
Closed
This was referenced Jul 22, 2024
Merged
Merged
@saschagrunert saschagrunert mentioned this pull request Aug 26, 2024
Merged
@github-actions github-actions bot mentioned this pull request Sep 25, 2024
Open
@caozhuozi caozhuozi mentioned this pull request Jan 29, 2025
Closed
@bergwolf bergwolf mentioned this pull request Feb 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@QiWang19 QiWang19 Awaiting requested review from QiWang19

@sohankunkerkar sohankunkerkar Awaiting requested review from sohankunkerkar

1 more reviewer

@kwilczynski kwilczynski kwilczynski left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kwilczynski kwilczynski

@saschagrunert saschagrunert

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@saschagrunert @kwilczynski @openshift-merge-robot